kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject kafka git commit: KAFKA-4749; Fix join-time-max and sync-time-max MeasurableStat type
Date Thu, 09 Feb 2017 02:41:54 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 8bd8751aa -> 6c1478d19


KAFKA-4749; Fix join-time-max and sync-time-max MeasurableStat type

GroupCoordinatorMetrics currently sets up join-time-max and sync-time-max incorrectly as a
"new Avg()" MeasurableStat instead of "new Max()"

Author: Onur Karaman <okaraman@linkedin.com>

Reviewers: Jason Gustafson <jason@confluent.io>

Closes #2520 from onurkaraman/KAFKA-4749


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/6c1478d1
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/6c1478d1
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/6c1478d1

Branch: refs/heads/trunk
Commit: 6c1478d19f5a9c8dede9e7c3b047533ba61cc731
Parents: 8bd8751
Author: Onur Karaman <okaraman@linkedin.com>
Authored: Wed Feb 8 18:41:14 2017 -0800
Committer: Jason Gustafson <jason@confluent.io>
Committed: Wed Feb 8 18:41:14 2017 -0800

----------------------------------------------------------------------
 .../kafka/clients/consumer/internals/AbstractCoordinator.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/6c1478d1/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
index 6eea045..2fdf802 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
@@ -794,7 +794,7 @@ public abstract class AbstractCoordinator implements Closeable {
                     "The average time taken for a group rejoin"), new Avg());
             this.joinLatency.add(metrics.metricName("join-time-max",
                     this.metricGrpName,
-                    "The max time taken for a group rejoin"), new Avg());
+                    "The max time taken for a group rejoin"), new Max());
             this.joinLatency.add(metrics.metricName("join-rate",
                     this.metricGrpName,
                     "The number of group joins per second"), new Rate(new Count()));
@@ -805,7 +805,7 @@ public abstract class AbstractCoordinator implements Closeable {
                     "The average time taken for a group sync"), new Avg());
             this.syncLatency.add(metrics.metricName("sync-time-max",
                     this.metricGrpName,
-                    "The max time taken for a group sync"), new Avg());
+                    "The max time taken for a group sync"), new Max());
             this.syncLatency.add(metrics.metricName("sync-rate",
                     this.metricGrpName,
                     "The number of group syncs per second"), new Rate(new Count()));


Mime
View raw message