kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: MINOR: update KafkaStreams.metadataForKey(...) javadoc
Date Fri, 10 Feb 2017 17:32:55 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 516d32849 -> 253dfcf47


MINOR: update KafkaStreams.metadataForKey(...) javadoc

Add a note to `KafkaStreams.metadataForKey(String, K, Serializer<K>)` to point out that
in the case of a Window Store the Serializer should still be the record key serializer and
not a window serializer

Author: Damian Guy <damian.guy@gmail.com>

Reviewers: Xavier Léauté, Guozhang Wang

Closes #2532 from dguy/minor-docs


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/253dfcf4
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/253dfcf4
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/253dfcf4

Branch: refs/heads/trunk
Commit: 253dfcf4756e8e0d434da69516993ea784f830c9
Parents: 516d328
Author: Damian Guy <damian.guy@gmail.com>
Authored: Fri Feb 10 09:32:52 2017 -0800
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Fri Feb 10 09:32:52 2017 -0800

----------------------------------------------------------------------
 streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/253dfcf4/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
index 6974b29..813b49e 100644
--- a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
+++ b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
@@ -635,6 +635,8 @@ public class KafkaStreams {
      *   <li>this is a point in time view and it may change due to partition reassignment</li>
      *   <li>the key may not exist in the {@link StateStore}; this method provides
a way of finding which host it
      *       <em>would</em> exist on</li>
+     *   <li>if this is for a window store the serializer should be the serializer
for the record key,
+     *       not the window serializer</li>
      * </ul>
      *
      * @param storeName     the {@code storeName} to find metadata for


Mime
View raw message