kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject kafka git commit: HOTFIX: Convert exception introduced in KAFKA-3637 to warning since clearly it is happening.
Date Tue, 10 Jan 2017 08:01:49 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 5401a17ad -> 54e2bd210


HOTFIX: Convert exception introduced in KAFKA-3637 to warning since clearly it is happening.

Author: Eno Thereska <eno.thereska@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #2283 from enothereska/hotfix-state-transition-warn


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/54e2bd21
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/54e2bd21
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/54e2bd21

Branch: refs/heads/trunk
Commit: 54e2bd210029b124be4835d5c50c56aa5edc5b38
Parents: 5401a17
Author: Eno Thereska <eno.thereska@gmail.com>
Authored: Mon Jan 9 23:53:38 2017 -0800
Committer: Ewen Cheslack-Postava <me@ewencp.org>
Committed: Mon Jan 9 23:53:38 2017 -0800

----------------------------------------------------------------------
 streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java   | 2 +-
 .../org/apache/kafka/streams/processor/internals/StreamThread.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/54e2bd21/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
index d2f388c..1ec10cb 100644
--- a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
+++ b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
@@ -189,7 +189,7 @@ public class KafkaStreams {
     private synchronized void setState(State newState) {
         State oldState = state;
         if (!state.isValidTransition(newState)) {
-            throw new IllegalStateException("Incorrect state transition from " + state +
" to " + newState);
+            log.warn("Unexpected state transition from " + state + " to " + newState);
         }
         state = newState;
         if (stateListener != null) {

http://git-wip-us.apache.org/repos/asf/kafka/blob/54e2bd21/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
b/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
index 6f58cc4..07c348d 100644
--- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
+++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
@@ -161,7 +161,7 @@ public class StreamThread extends Thread {
     private synchronized void setState(State newState) {
         State oldState = state;
         if (!state.isValidTransition(newState)) {
-            throw new IllegalStateException("Incorrect state transition from " + state +
" to " + newState);
+            log.warn("Unexpected state transition from " + state + " to " + newState);
         }
         state = newState;
         if (stateListener != null) {


Mime
View raw message