kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: MINOR: Clarify log deletion configuration options in server.properties
Date Wed, 21 Dec 2016 01:39:14 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 68f204e01 -> ecc0fc447


MINOR: Clarify log deletion configuration options in server.properties

I spent a bit of time tracking down why files were being deleted before they reached log.retention.hours
of age. It turns out that the time and size log retention schemes function independently,
and not as the original comment "The minimum age of a log file to be eligible for deletion"
might indicate to a new user.

Author: Mark Rose <markrose@markrose.ca>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #28 from MarkRose/fix_misleading_configuration_file_for_trunk


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/ecc0fc44
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/ecc0fc44
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/ecc0fc44

Branch: refs/heads/trunk
Commit: ecc0fc447a496494130648820e5b9c3536fc78f6
Parents: 68f204e
Author: Mark Rose <markrose@markrose.ca>
Authored: Tue Dec 20 17:39:07 2016 -0800
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Tue Dec 20 17:39:07 2016 -0800

----------------------------------------------------------------------
 config/server.properties | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/ecc0fc44/config/server.properties
----------------------------------------------------------------------
diff --git a/config/server.properties b/config/server.properties
index f00a7d6..60479b2 100644
--- a/config/server.properties
+++ b/config/server.properties
@@ -92,11 +92,11 @@ num.recovery.threads.per.data.dir=1
 # A segment will be deleted whenever *either* of these criteria are met. Deletion always
happens
 # from the end of the log.
 
-# The minimum age of a log file to be eligible for deletion
+# The minimum age of a log file to be eligible for deletion due to age
 log.retention.hours=168
 
 # A size-based retention policy for logs. Segments are pruned from the log as long as the
remaining
-# segments don't drop below log.retention.bytes.
+# segments don't drop below log.retention.bytes. Functions independently of log.retention.hours.
 #log.retention.bytes=1073741824
 
 # The maximum size of a log segment file. When this size is reached a new log segment will
be created.


Mime
View raw message