kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject kafka git commit: MINOR: Fix export command for additional env vars in connect system tests
Date Fri, 11 Nov 2016 23:00:45 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 7282de39f -> 4f1d8c685


MINOR: Fix export command for additional env vars in connect system tests

Author: Konstantine Karantasis <konstantine@confluent.io>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #2126 from kkonstantine/MINOR-Fix-formatting-of-env-vars-in-connect-system-test-template


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/4f1d8c68
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/4f1d8c68
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/4f1d8c68

Branch: refs/heads/trunk
Commit: 4f1d8c6859c5767c314de84bd654cb7e1153db4b
Parents: 7282de3
Author: Konstantine Karantasis <konstantine@confluent.io>
Authored: Fri Nov 11 15:00:40 2016 -0800
Committer: Ewen Cheslack-Postava <me@ewencp.org>
Committed: Fri Nov 11 15:00:40 2016 -0800

----------------------------------------------------------------------
 tests/kafkatest/services/connect.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/4f1d8c68/tests/kafkatest/services/connect.py
----------------------------------------------------------------------
diff --git a/tests/kafkatest/services/connect.py b/tests/kafkatest/services/connect.py
index 091eaf7..473eb0b 100644
--- a/tests/kafkatest/services/connect.py
+++ b/tests/kafkatest/services/connect.py
@@ -210,7 +210,7 @@ class ConnectStandaloneService(ConnectServiceBase):
         cmd = "( export KAFKA_LOG4J_OPTS=\"-Dlog4j.configuration=file:%s\"; " % self.LOG4J_CONFIG_FILE
         cmd += "export KAFKA_OPTS=%s; " % self.security_config.kafka_opts
         for envvar in self.environment:
-            cmd += "export %s=%s; " % envvar, str(self.environment[envvar])
+            cmd += "export %s=%s; " % (envvar, str(self.environment[envvar]))
         cmd += "%s %s " % (self.path.script("connect-standalone.sh", node), self.CONFIG_FILE)
         cmd += " ".join(connector_configs)
         cmd += " & echo $! >&3 ) 1>> %s 2>> %s 3> %s" % (self.STDOUT_FILE,
self.STDERR_FILE, self.PID_FILE)
@@ -253,7 +253,7 @@ class ConnectDistributedService(ConnectServiceBase):
         cmd = "( export KAFKA_LOG4J_OPTS=\"-Dlog4j.configuration=file:%s\"; " % self.LOG4J_CONFIG_FILE
         cmd += "export KAFKA_OPTS=%s; " % self.security_config.kafka_opts
         for envvar in self.environment:
-            cmd += "export %s=%s; " % envvar, str(self.environment[envvar])
+            cmd += "export %s=%s; " % (envvar, str(self.environment[envvar]))
         cmd += "%s %s " % (self.path.script("connect-distributed.sh", node), self.CONFIG_FILE)
         cmd += " & echo $! >&3 ) 1>> %s 2>> %s 3> %s" % (self.STDOUT_FILE,
self.STDERR_FILE, self.PID_FILE)
         return cmd


Mime
View raw message