kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject kafka git commit: MINOR: Make release notes script check resolutions to avoid spurious inclusion of non-fix 'fixes' in release notes.
Date Tue, 29 Nov 2016 19:36:19 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 7d0f3e75a -> b11ead580


MINOR: Make release notes script check resolutions to avoid spurious inclusion of non-fix
'fixes' in release notes.

Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #2174 from ewencp/release-notes-resolution-filters


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/b11ead58
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/b11ead58
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/b11ead58

Branch: refs/heads/trunk
Commit: b11ead58041f6618b4d585dda32f2d71ef0da46a
Parents: 7d0f3e7
Author: Ewen Cheslack-Postava <me@ewencp.org>
Authored: Tue Nov 29 11:36:06 2016 -0800
Committer: Ewen Cheslack-Postava <me@ewencp.org>
Committed: Tue Nov 29 11:36:06 2016 -0800

----------------------------------------------------------------------
 release_notes.py | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/b11ead58/release_notes.py
----------------------------------------------------------------------
diff --git a/release_notes.py b/release_notes.py
index b8b2ea1..432b06c 100755
--- a/release_notes.py
+++ b/release_notes.py
@@ -61,11 +61,28 @@ if __name__ == "__main__":
         print >>sys.stderr, "Didn't find any issues for the target fix version"
         sys.exit(1)
 
-    unresolved_issues = [issue for issue in issues if issue.fields.resolution is None]
+    # Some resolutions, including a lack of resolution, indicate that the bug hasn't actually
been addressed and we shouldn't even be able to create a release until they are fixed
+    UNRESOLVED_RESOLUTIONS = [None,
+                              "Unresolved",
+                              "Duplicate",
+                              "Invalid",
+                              "Not A Problem",
+                              "Not A Bug",
+                              "Won't Fix",
+                              "Incomplete",
+                              "Cannot Reproduce",
+                              "Later",
+                              "Works for Me",
+                              "Workaround",
+                              "Information Provided"
+                              ]
+    unresolved_issues = [issue for issue in issues if issue.fields.resolution in UNRESOLVED_RESOLUTIONS
or issue.fields.resolution.name in UNRESOLVED_RESOLUTIONS]
     if unresolved_issues:
-        print >>sys.stderr, "The release is not completed since unresolved issues were
found still tagged with this release as the fix version:"
+        print >>sys.stderr, "The release is not completed since unresolved issues or
improperly resolved issues were found still tagged with this release as the fix version:"
         for issue in unresolved_issues:
-            print >>sys.stderr, "Unresolved issue: %s %s" % (issue.key, issue_link(issue))
+            print >>sys.stderr, "Unresolved issue: %15s %20s %s" % (issue.key, issue.fields.resolution,
issue_link(issue))
+        print >>sys.stderr
+        print >>sys.stderr, "Note that for some resolutions, you should simply remove
the fix version as they have not been truly fixed in this release."
         sys.exit(1)
 
     # Get list of (issue type, [issues]) sorted by the issue ID type, with each subset of
issues sorted by their key so they


Mime
View raw message