kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Include TopicPartition in warning when log cleaner resets dirty offset
Date Wed, 07 Sep 2016 00:16:01 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk de1b853c3 -> 8248caf1c


MINOR: Include TopicPartition in warning when log cleaner resets dirty offset

Typically this error condition is caused by topic-level configuration issues, so it is useful
to include which topic partition was reset for operator use when debugging the root cause.

Author: Dana Powers <dana.powers@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1801 from dpkp/log_topic_partition_reset_dirty_offset


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/8248caf1
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/8248caf1
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/8248caf1

Branch: refs/heads/trunk
Commit: 8248caf1ca514adcbc6130d6674cad39275fdd36
Parents: de1b853
Author: Dana Powers <dana.powers@gmail.com>
Authored: Wed Sep 7 01:15:55 2016 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Wed Sep 7 01:15:55 2016 +0100

----------------------------------------------------------------------
 core/src/main/scala/kafka/log/LogCleanerManager.scala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/8248caf1/core/src/main/scala/kafka/log/LogCleanerManager.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/log/LogCleanerManager.scala b/core/src/main/scala/kafka/log/LogCleanerManager.scala
index c1068f8..a601ede 100755
--- a/core/src/main/scala/kafka/log/LogCleanerManager.scala
+++ b/core/src/main/scala/kafka/log/LogCleanerManager.scala
@@ -92,8 +92,8 @@ private[log] class LogCleanerManager(val logDirs: Array[File], val logs:
Pool[To
             if (offset < logStartOffset) {
               // don't bother with the warning if compact and delete are enabled.
               if (!isCompactAndDelete(log))
-                warn("Resetting first dirty offset to log start offset %d since the checkpointed
offset %d is invalid."
-                    .format(logStartOffset, offset))
+                warn("Resetting first dirty offset for %s to log start offset %d since the
checkpointed offset %d is invalid."
+                    .format(topicAndPartition, logStartOffset, offset))
               logStartOffset
             } else {
               offset


Mime
View raw message