kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: MINOR: Fixes javadoc of Windows, fixes typo in parameter name of KGroupedTable
Date Wed, 07 Sep 2016 22:28:04 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 85c441023 -> 3a244b783


MINOR: Fixes javadoc of Windows, fixes typo in parameter name of KGroupedTable

Author: Michael G. Noll <michael@confluent.io>

Reviewers: Damian Guy, Ismael Juma, Guozhang Wang

Closes #1823 from miguno/trunk-windowed-javadocs


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/3a244b78
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/3a244b78
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/3a244b78

Branch: refs/heads/trunk
Commit: 3a244b78372373ea1028fa77eef8b7c739001bd2
Parents: 85c4410
Author: Michael G. Noll <michael@confluent.io>
Authored: Wed Sep 7 15:27:58 2016 -0700
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Wed Sep 7 15:27:58 2016 -0700

----------------------------------------------------------------------
 .../java/org/apache/kafka/streams/kstream/KGroupedTable.java | 8 ++++----
 .../main/java/org/apache/kafka/streams/kstream/Windowed.java | 6 +++---
 .../kafka/streams/kstream/internals/KGroupedTableImpl.java   | 4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/3a244b78/streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedTable.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedTable.java b/streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedTable.java
index a6b2798..3ba4f22 100644
--- a/streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedTable.java
+++ b/streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedTable.java
@@ -59,7 +59,7 @@ public interface KGroupedTable<K, V> {
      *
      * @param initializer   the instance of {@link Initializer}
      * @param adder         the instance of {@link Aggregator} for addition
-     * @param substractor   the instance of {@link Aggregator} for subtraction
+     * @param subtractor    the instance of {@link Aggregator} for subtraction
      * @param aggValueSerde value serdes for materializing the aggregated table,
      *                      if not specified the default serdes defined in the configs will
be used
      * @param storeName     the name of the underlying {@link KTable} state store
@@ -69,7 +69,7 @@ public interface KGroupedTable<K, V> {
      */
     <T> KTable<K, T> aggregate(Initializer<T> initializer,
                                Aggregator<K, V, T> adder,
-                               Aggregator<K, V, T> substractor,
+                               Aggregator<K, V, T> subtractor,
                                Serde<T> aggValueSerde,
                                String storeName);
 
@@ -83,7 +83,7 @@ public interface KGroupedTable<K, V> {
      *
      * @param initializer   the instance of {@link Initializer}
      * @param adder         the instance of {@link Aggregator} for addition
-     * @param substractor   the instance of {@link Aggregator} for subtraction
+     * @param subtractor   the instance of {@link Aggregator} for subtraction
      * @param storeName     the name of the underlying {@link KTable} state store
      * @param <T>           the value type of the aggregated {@link KTable}
      * @return a {@link KTable} with same key and aggregated value type {@code T},
@@ -91,7 +91,7 @@ public interface KGroupedTable<K, V> {
      */
     <T> KTable<K, T> aggregate(Initializer<T> initializer,
                                Aggregator<K, V, T> adder,
-                               Aggregator<K, V, T> substractor,
+                               Aggregator<K, V, T> subtractor,
                                String storeName);
 
     /**

http://git-wip-us.apache.org/repos/asf/kafka/blob/3a244b78/streams/src/main/java/org/apache/kafka/streams/kstream/Windowed.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/Windowed.java b/streams/src/main/java/org/apache/kafka/streams/kstream/Windowed.java
index feaf6a3..6606fcb 100644
--- a/streams/src/main/java/org/apache/kafka/streams/kstream/Windowed.java
+++ b/streams/src/main/java/org/apache/kafka/streams/kstream/Windowed.java
@@ -18,9 +18,9 @@
 package org.apache.kafka.streams.kstream;
 
 /**
- * The windowed key interface used in {@link KTable}, used for representing a windowed table
result from windowed stream aggregations,
- * i.e. {@link KStream#aggregateByKey(Initializer, Aggregator, Windows, org.apache.kafka.common.serialization.Serde,
- * org.apache.kafka.common.serialization.Serde)}
+ * Used to represent windowed stream aggregations (e.g. as returned by
+ * {@link KGroupedStream#aggregate(Initializer, Aggregator, Windows, org.apache.kafka.common.serialization.Serde,
String)}),
+ * which have the type {@code <Windowed<K>, V>}.
  *
  * @param <K> Type of the key
  */

http://git-wip-us.apache.org/repos/asf/kafka/blob/3a244b78/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImpl.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImpl.java
b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImpl.java
index 6d6e8cc..82a800d 100644
--- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImpl.java
+++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImpl.java
@@ -77,10 +77,10 @@ public class KGroupedTableImpl<K, V> extends AbstractStream<K>
implements KGroup
     @Override
     public <T> KTable<K, T> aggregate(Initializer<T> initializer,
                             Aggregator<K, V, T> adder,
-                            Aggregator<K, V, T> substractor,
+                            Aggregator<K, V, T> subtractor,
                             String storeName) {
 
-        return aggregate(initializer, adder, substractor, null, storeName);
+        return aggregate(initializer, adder, subtractor, null, storeName);
     }
 
     private <T> KTable<K, T> doAggregate(ProcessorSupplier<K, Change<V>>
aggregateSupplier,


Mime
View raw message