kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: KAFKA-4197; Make ReassignPartitionsTest System Test move data
Date Tue, 20 Sep 2016 14:41:52 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.1 d48415f18 -> 29e30a79e


KAFKA-4197; Make ReassignPartitionsTest System Test move data

The ReassignPartitionsTest system tests doesn't reassign any replicas (i.e. move data).

This is a simple issue. It uses a 3 node cluster with replication factor of 3, so whilst the
replicas are jumbled around, nothing actually is moved from machine to machine when the assignment
is executed.

This fix just ups the number of nodes to 4 so things move.

Tests pass locally.
There are runs pending on the two branch builders

Passes:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/551/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/94/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/553/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/554/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/95

Failures:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/552 => _RuntimeError:
There aren't enough available nodes to satisfy the resource request. Total cluster size: 1,
Requested: 4, Already allocated: 1, Available: 0._ Which I assume to do with the test env.

Author: Ben Stopford <benstopford@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1892 from benstopford/fix_reassignment_test

(cherry picked from commit 4f821830bc6b726cddf90999fff76006745b1a3f)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/29e30a79
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/29e30a79
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/29e30a79

Branch: refs/heads/0.10.1
Commit: 29e30a79e5ba4f137d77943976b1e8e77f6ccaac
Parents: d48415f
Author: Ben Stopford <benstopford@gmail.com>
Authored: Tue Sep 20 15:41:14 2016 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Tue Sep 20 15:41:27 2016 +0100

----------------------------------------------------------------------
 tests/kafkatest/tests/core/reassign_partitions_test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/29e30a79/tests/kafkatest/tests/core/reassign_partitions_test.py
----------------------------------------------------------------------
diff --git a/tests/kafkatest/tests/core/reassign_partitions_test.py b/tests/kafkatest/tests/core/reassign_partitions_test.py
index 24ce097..dfff597 100644
--- a/tests/kafkatest/tests/core/reassign_partitions_test.py
+++ b/tests/kafkatest/tests/core/reassign_partitions_test.py
@@ -37,7 +37,7 @@ class ReassignPartitionsTest(ProduceConsumeValidateTest):
 
         self.topic = "test_topic"
         self.zk = ZookeeperService(test_context, num_nodes=1)
-        self.kafka = KafkaService(test_context, num_nodes=3, zk=self.zk, topics={self.topic:
{
+        self.kafka = KafkaService(test_context, num_nodes=4, zk=self.zk, topics={self.topic:
{
                                                                     "partitions": 20,
                                                                     "replication-factor":
3,
                                                                     'configs': {"min.insync.replicas":
2}}


Mime
View raw message