kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: KAFKA-4018; Streams causing older slf4j-log4j library to be packaged along with newer version
Date Thu, 04 Aug 2016 01:04:43 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.0 127bb7fca -> ac994dd76


KAFKA-4018; Streams causing older slf4j-log4j library to be packaged along with newer version

This is a regression caused by 0bb1d3ae.

After that commit, Streams no longer has a direct dependency on slf4j-log4j12, but zkclient
has a dependency on an older version of slf4j-log4j12, so we get a transitive dependency on
the older version.

The fix is to simply exclude the undesired dependencies from the zkclient dependency.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1704 from ijuma/kafka-4018-streams-duplicate-slf4j-log4j

(cherry picked from commit 2e3722a234df5c0cd2e91c258cc0e4d825ee0626)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/ac994dd7
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/ac994dd7
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/ac994dd7

Branch: refs/heads/0.10.0
Commit: ac994dd7651937c19cfa50e7d4e3685b76eacac5
Parents: 127bb7f
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Thu Aug 4 02:03:57 2016 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Thu Aug 4 02:04:38 2016 +0100

----------------------------------------------------------------------
 build.gradle | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/ac994dd7/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index 36647b3..b565200 100644
--- a/build.gradle
+++ b/build.gradle
@@ -674,6 +674,9 @@ project(':streams') {
     compile libs.rocksDBJni
     // this dependency should be removed after KIP-4
     compile (libs.zkclient) {
+      // users should be able to choose the logging implementation (and slf4j bridge)
+      exclude module: 'slf4j-log4j12'
+      exclude module: 'log4j'
       exclude module: 'jline'
       exclude module: 'netty'
     }


Mime
View raw message