kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gwens...@apache.org
Subject kafka git commit: MINOR: lower logging severity for offset reset
Date Mon, 01 Aug 2016 16:08:24 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk cd767aee4 -> 2a9f7af6c


MINOR: lower logging severity for offset reset

When resetting the first dirty offset to the log start offset, we currently log an ERROR which
makes users think the log cleaner has a problem and maybe has exited.  We should log a WARN
instead to avoid alarming the users.

Author: Dustin Cote <dustin@confluent.io>

Reviewers: Gwen Shapira

Closes #1691 from cotedm/minorlogcleanerlogging


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/2a9f7af6
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/2a9f7af6
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/2a9f7af6

Branch: refs/heads/trunk
Commit: 2a9f7af6c28ace1fc0bf8f64127e39b7ec13940a
Parents: cd767ae
Author: Dustin Cote <dustin@confluent.io>
Authored: Mon Aug 1 09:08:18 2016 -0700
Committer: Gwen Shapira <cshapi@gmail.com>
Committed: Mon Aug 1 09:08:18 2016 -0700

----------------------------------------------------------------------
 core/src/main/scala/kafka/log/LogCleanerManager.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/2a9f7af6/core/src/main/scala/kafka/log/LogCleanerManager.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/log/LogCleanerManager.scala b/core/src/main/scala/kafka/log/LogCleanerManager.scala
index 72757c0..60bcba6 100755
--- a/core/src/main/scala/kafka/log/LogCleanerManager.scala
+++ b/core/src/main/scala/kafka/log/LogCleanerManager.scala
@@ -90,7 +90,7 @@ private[log] class LogCleanerManager(val logDirs: Array[File], val logs:
Pool[To
           val firstDirtyOffset = {
             val offset = lastClean.getOrElse(topicAndPartition, logStartOffset)
             if (offset < logStartOffset) {
-              error("Resetting first dirty offset to log start offset %d since the checkpointed
offset %d is invalid."
+              warn("Resetting first dirty offset to log start offset %d since the checkpointed
offset %d is invalid."
                     .format(logStartOffset, offset))
               logStartOffset
             } else {


Mime
View raw message