kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject kafka git commit: KAFKA-2932: Adjust importance level of Kafka Connect configs
Date Sun, 07 Aug 2016 04:58:40 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 8d303d0d3 -> 29f44e75c


KAFKA-2932: Adjust importance level of Kafka Connect configs

ewencp I went down the list of connect configs and it looks like only the internal converter
configs are mismarked.  It looks like the `cluster` config that is present in the current
docs is already gone.  The only other values I can see arguing to change importance on are
the ssl configs (marked high) but they are consistent with the producer/consumer config docs
so that's at least consistent.  Everything else marked high looks either mandatory or requires
consideration in a production deployment to me.

Author: Dustin Cote <dustin@confluent.io>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1653 from cotedm/KAFKA-2932


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/29f44e75
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/29f44e75
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/29f44e75

Branch: refs/heads/trunk
Commit: 29f44e75cd4ade107b169dbf43bbcb191013e75f
Parents: 8d303d0
Author: Dustin Cote <dustin@confluent.io>
Authored: Sat Aug 6 21:59:22 2016 -0700
Committer: Ewen Cheslack-Postava <me@ewencp.org>
Committed: Sat Aug 6 21:59:22 2016 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/kafka/connect/runtime/WorkerConfig.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/29f44e75/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
----------------------------------------------------------------------
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
index c9c4e60..fc3fe71 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
@@ -139,9 +139,9 @@ public class WorkerConfig extends AbstractConfig {
                 .define(VALUE_CONVERTER_CLASS_CONFIG, Type.CLASS,
                         Importance.HIGH, VALUE_CONVERTER_CLASS_DOC)
                 .define(INTERNAL_KEY_CONVERTER_CLASS_CONFIG, Type.CLASS,
-                        Importance.HIGH, INTERNAL_KEY_CONVERTER_CLASS_DOC)
+                        Importance.LOW, INTERNAL_KEY_CONVERTER_CLASS_DOC)
                 .define(INTERNAL_VALUE_CONVERTER_CLASS_CONFIG, Type.CLASS,
-                        Importance.HIGH, INTERNAL_VALUE_CONVERTER_CLASS_DOC)
+                        Importance.LOW, INTERNAL_VALUE_CONVERTER_CLASS_DOC)
                 .define(TASK_SHUTDOWN_GRACEFUL_TIMEOUT_MS_CONFIG, Type.LONG,
                         TASK_SHUTDOWN_GRACEFUL_TIMEOUT_MS_DEFAULT, Importance.LOW,
                         TASK_SHUTDOWN_GRACEFUL_TIMEOUT_MS_DOC)


Mime
View raw message