kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: KAFKA-3844; Sort configuration items in log
Date Sat, 09 Jul 2016 01:04:52 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 0edaa89be -> 4b5ed36c2


KAFKA-3844; Sort configuration items in log

KAFKA-3844; Sort configuration items in log

Author: Rekha Joshi <rekhajoshm@gmail.com>
Author: Joshi <rekhajoshm@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1559 from rekhajoshm/KAFKA-3844


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/4b5ed36c
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/4b5ed36c
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/4b5ed36c

Branch: refs/heads/trunk
Commit: 4b5ed36c2264808c33f92ccfdc456a19af3471bd
Parents: 0edaa89
Author: Rekha Joshi <rekhajoshm@gmail.com>
Authored: Sat Jul 9 02:04:52 2016 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Sat Jul 9 02:04:52 2016 +0100

----------------------------------------------------------------------
 .../main/java/org/apache/kafka/common/config/AbstractConfig.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/4b5ed36c/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java b/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
index 1feea8d..91c5a9f 100644
--- a/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
+++ b/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
@@ -26,6 +26,7 @@ import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import java.util.TreeMap;
 
 /**
  * A convenient base class for configurations to extend.
@@ -168,7 +169,8 @@ public class AbstractConfig {
         b.append(getClass().getSimpleName());
         b.append(" values: ");
         b.append(Utils.NL);
-        for (Map.Entry<String, Object> entry : this.values.entrySet()) {
+
+        for (Map.Entry<String, Object> entry : new TreeMap<>(this.values).entrySet())
{
             b.append('\t');
             b.append(entry.getKey());
             b.append(" = ");


Mime
View raw message