kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Doc of 'retries' config should mention max.in.flight.requests.per.connection to avoid confusion
Date Tue, 19 Jul 2016 09:11:11 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.0 dfd5946d8 -> b670790bc


MINOR: Doc of 'retries' config should mention max.in.flight.requests.per.connection to avoid
confusion

Author: Yuto Kawamura <kawamuray.dadada@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1607 from kawamuray/MINOR-retries-doc

(cherry picked from commit 7354cc1f487cea5c0422c8e80c3aed244321dbfd)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/b670790b
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/b670790b
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/b670790b

Branch: refs/heads/0.10.0
Commit: b670790bc67de08bcd23806cd63c2454c3675664
Parents: dfd5946
Author: Yuto Kawamura <kawamuray.dadada@gmail.com>
Authored: Tue Jul 19 10:10:25 2016 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Tue Jul 19 10:11:05 2016 +0100

----------------------------------------------------------------------
 .../kafka/clients/producer/ProducerConfig.java      | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/b670790b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
index 4d121b9..e07519c 100644
--- a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
+++ b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
@@ -159,14 +159,6 @@ public class ProducerConfig extends AbstractConfig {
                                                     + "not all memory the producer uses is
used for buffering. Some additional memory will be used for compression (if "
                                                     + "compression is enabled) as well as
for maintaining in-flight requests.";
 
-    /** <code>retries</code> */
-    public static final String RETRIES_CONFIG = "retries";
-    private static final String RETRIES_DOC = "Setting a value greater than zero will cause
the client to resend any record whose send fails with a potentially transient error."
-                                              + " Note that this retry is no different than
if the client resent the record upon receiving the "
-                                              + "error. Allowing retries will potentially
change the ordering of records because if two records are "
-                                              + "sent to a single partition, and the first
fails and is retried but the second succeeds, then the second record "
-                                              + "may appear first.";
-
     /** <code>retry.backoff.ms</code> */
     public static final String RETRY_BACKOFF_MS_CONFIG = CommonClientConfigs.RETRY_BACKOFF_MS_CONFIG;
 
@@ -191,6 +183,14 @@ public class ProducerConfig extends AbstractConfig {
                                                                             + " Note that
if this setting is set to be greater than 1 and there are failed sends, there is a risk of"
                                                                             + " message re-ordering
due to retries (i.e., if retries are enabled).";
 
+    /** <code>retries</code> */
+    public static final String RETRIES_CONFIG = "retries";
+    private static final String RETRIES_DOC = "Setting a value greater than zero will cause
the client to resend any record whose send fails with a potentially transient error."
+                                              + " Note that this retry is no different than
if the client resent the record upon receiving the error."
+                                              + " Allowing retries without setting <code>"
+ MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + "</code> to 1 will potentially change the"
+                                              + " ordering of records because if two batches
are sent to a single partition, and the first fails and is retried but the second"
+                                              + " succeeds, then the records in the second
batch may appear first.";
+
     /** <code>key.serializer</code> */
     public static final String KEY_SERIALIZER_CLASS_CONFIG = "key.serializer";
     public static final String KEY_SERIALIZER_CLASS_DOC = "Serializer class for key that
implements the <code>Serializer</code> interface.";


Mime
View raw message