kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: MINOR: Remove slf4j-log4j from kafka-streams compile dependencies
Date Tue, 19 Jul 2016 22:45:16 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk f1dd0d272 -> cfebfdfa5


MINOR: Remove slf4j-log4j from kafka-streams compile dependencies

As kafka-streams is intended to be used by applications that may or may not wish to use log4j,
kafka-streams itself should not have a dependency on a concrete log framework.  This change
adapts the dependencies to be API-only for compile, and framework-specific for the test runtime
only.

I read through the [Contributing Code Guidelines](https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes)
and interpreted this as a trivial change that doesn't require a Jira ticket.  Please let me
know if I've interpreted that wrongly.

This contribution is my original work and I license the work to the project under the project's
open source license.

Author: Mathieu Fenniak <mathieu@encouragemarketing.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1639 from mfenniak/fix-slf4j-dependency-for-streams


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/cfebfdfa
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/cfebfdfa
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/cfebfdfa

Branch: refs/heads/trunk
Commit: cfebfdfa5e537946e4c6e1cc986f20131899be31
Parents: f1dd0d2
Author: Mathieu Fenniak <mathieu@encouragemarketing.com>
Authored: Tue Jul 19 15:45:12 2016 -0700
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Tue Jul 19 15:45:12 2016 -0700

----------------------------------------------------------------------
 build.gradle | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/cfebfdfa/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index b3be020..c76ff2a 100644
--- a/build.gradle
+++ b/build.gradle
@@ -677,7 +677,7 @@ project(':streams') {
   dependencies {
     compile project(':clients')
     compile project(':connect:json')  // this dependency should be removed after we unify
data API
-    compile libs.slf4jlog4j
+    compile libs.slf4jApi
     compile libs.rocksDBJni
     // this dependency should be removed after KIP-4
     compile (libs.zkclient) {
@@ -690,6 +690,8 @@ project(':streams') {
     testCompile project(':core')
     testCompile project(':core').sourceSets.test.output
     testCompile libs.junit
+
+    testRuntime libs.slf4jlog4j
   }
 
   javadoc {


Mime
View raw message