kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject kafka git commit: KAFKA-3774: Make 'time' an optional argument of GetOffsetShell
Date Thu, 02 Jun 2016 05:53:48 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 107205a7f -> e6ca328f8


KAFKA-3774: Make 'time' an optional argument of GetOffsetShell

Since the 'time' argument has a default value of -1, it makes sense to make it an optional
argument.

Author: Vahid Hashemian <vahidhashemian@us.ibm.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1457 from vahidhashemian/KAFKA-3774


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/e6ca328f
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/e6ca328f
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/e6ca328f

Branch: refs/heads/trunk
Commit: e6ca328f80a8f7504d740c9f77dfc8b04db20324
Parents: 107205a
Author: Vahid Hashemian <vahidhashemian@us.ibm.com>
Authored: Wed Jun 1 22:53:35 2016 -0700
Committer: Ewen Cheslack-Postava <me@ewencp.org>
Committed: Wed Jun 1 22:53:35 2016 -0700

----------------------------------------------------------------------
 core/src/main/scala/kafka/tools/GetOffsetShell.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/e6ca328f/core/src/main/scala/kafka/tools/GetOffsetShell.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/tools/GetOffsetShell.scala b/core/src/main/scala/kafka/tools/GetOffsetShell.scala
index f7207ec..979354b 100644
--- a/core/src/main/scala/kafka/tools/GetOffsetShell.scala
+++ b/core/src/main/scala/kafka/tools/GetOffsetShell.scala
@@ -64,7 +64,7 @@ object GetOffsetShell {
 
     val options = parser.parse(args : _*)
 
-    CommandLineUtils.checkRequiredArgs(parser, options, brokerListOpt, topicOpt, timeOpt)
+    CommandLineUtils.checkRequiredArgs(parser, options, brokerListOpt, topicOpt)
 
     val clientId = "GetOffsetShell"
     val brokerList = options.valueOf(brokerListOpt)


Mime
View raw message