kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Clean up of ConsumerCoordinator and PartitionAssignor
Date Tue, 03 May 2016 22:55:38 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.0 96f6aa8c4 -> 4de0ed7d5


MINOR: Clean up of ConsumerCoordinator and PartitionAssignor

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Jason Gustafson <jason@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #1306 from Ishiihara/minor-consumer-cleanup

(cherry picked from commit af013788436ae5652b531184770f2620f8914123)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/4de0ed7d
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/4de0ed7d
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/4de0ed7d

Branch: refs/heads/0.10.0
Commit: 4de0ed7d525a03cf41a855c0ef22d8f98224914f
Parents: 96f6aa8
Author: Liquan Pei <liquanpei@gmail.com>
Authored: Tue May 3 23:42:03 2016 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Tue May 3 23:54:59 2016 +0100

----------------------------------------------------------------------
 .../kafka/clients/consumer/internals/ConsumerCoordinator.java      | 2 +-
 .../apache/kafka/clients/consumer/internals/PartitionAssignor.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/4de0ed7d/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
index 887f47c..7486969 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
@@ -62,7 +62,7 @@ public final class ConsumerCoordinator extends AbstractCoordinator {
     private static final Logger log = LoggerFactory.getLogger(ConsumerCoordinator.class);
 
     private final List<PartitionAssignor> assignors;
-    private final org.apache.kafka.clients.Metadata metadata;
+    private final Metadata metadata;
     private final ConsumerCoordinatorMetrics sensors;
     private final SubscriptionState subscriptions;
     private final OffsetCommitCallback defaultOffsetCommitCallback;

http://git-wip-us.apache.org/repos/asf/kafka/blob/4de0ed7d/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
index 46bfa75..df8f2f1 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/PartitionAssignor.java
@@ -39,7 +39,7 @@ public interface PartitionAssignor {
      * Return a serializable object representing the local member's subscription. This can
include
      * additional information as well (e.g. local host/rack information) which can be leveraged
in
      * {@link #assign(Cluster, Map)}.
-     * @param topics Topics subscribed to through {@link org.apache.kafka.clients.consumer.KafkaConsumer#subscribe(List)}
+     * @param topics Topics subscribed to through {@link org.apache.kafka.clients.consumer.KafkaConsumer#subscribe(java.util.Collection)}
      *               and variants
      * @return Non-null subscription with optional user data
      */


Mime
View raw message