kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Fix checkstyle failure in `StreamsConfigTest`
Date Thu, 12 May 2016 19:37:04 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.0 553cc6487 -> 056a78dff


MINOR: Fix checkstyle failure in `StreamsConfigTest`

I removed the hamcrest matcher to unbreak the build, but we probably want to tweak the `import-control.xml`
as it currently only allows it for `<subpackage name="integration">`, which is weird.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1380 from ijuma/fix-streams-config-test-checkstyle

(cherry picked from commit ac434a4ebdc36338ff707c38e189f9d1668ff423)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/056a78df
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/056a78df
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/056a78df

Branch: refs/heads/0.10.0
Commit: 056a78dff96ee96e8c9481d16081645f511960ab
Parents: 553cc64
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Thu May 12 20:36:47 2016 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Thu May 12 20:36:59 2016 +0100

----------------------------------------------------------------------
 .../test/java/org/apache/kafka/streams/StreamsConfigTest.java    | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/056a78df/streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
----------------------------------------------------------------------
diff --git a/streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java b/streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
index d7def70..17d6b4b 100644
--- a/streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
@@ -30,10 +30,8 @@ import java.util.List;
 import java.util.Map;
 import java.util.Properties;
 
-import static org.hamcrest.CoreMatchers.equalTo;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertThat;
 
 public class StreamsConfigTest {
 
@@ -101,7 +99,7 @@ public class StreamsConfigTest {
         StreamsConfig config = new StreamsConfig(props);
 
         List<String> actualBootstrapServers = config.getList(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG);
-        assertThat(actualBootstrapServers, equalTo(expectedBootstrapServers));
+        assertEquals(expectedBootstrapServers, actualBootstrapServers);
     }
 
 }


Mime
View raw message