kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gwens...@apache.org
Subject kafka git commit: MINOR: Exclude jline, netty and findbugs annotations
Date Wed, 18 May 2016 02:19:30 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.0 7c6ee8d5e -> 050ca1f03


MINOR: Exclude jline, netty and findbugs annotations

These dependencies are unnecessary and they are acquired
transitively via zkclient (jline, netty) and reflections (annotations).

Ewen did the hard work in figuring out why we have unexpected
additional dependencies since 0.9.x.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Ewen Cheslack-Postava, Guozhang Wang, Gwen Shapira

Closes #1396 from ijuma/exclude-jline-netty-deps-in-streams and squashes the following commits:

3aa366f [Ismael Juma] Exclude findbugs annotations due to LGPL license
2d3d714 [Ismael Juma] Use local exclusion for `jline` and `netty`
482b6c0 [Ismael Juma] Exclude `jline` and `netty` dependencies in the `streams` project


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/050ca1f0
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/050ca1f0
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/050ca1f0

Branch: refs/heads/0.10.0
Commit: 050ca1f0304ad35dfb727fc8f67813b39df16c22
Parents: 7c6ee8d
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Tue May 17 19:18:33 2016 -0700
Committer: Gwen Shapira <cshapi@gmail.com>
Committed: Tue May 17 19:19:23 2016 -0700

----------------------------------------------------------------------
 build.gradle | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/050ca1f0/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index 06c41d5..4aa636b 100644
--- a/build.gradle
+++ b/build.gradle
@@ -665,7 +665,11 @@ project(':streams') {
     compile project(':connect:json')  // this dependency should be removed after we unify
data API
     compile libs.slf4jlog4j
     compile libs.rocksDBJni
-    compile libs.zkclient // this dependency should be removed after KIP-4
+    // this dependency should be removed after KIP-4
+    compile (libs.zkclient) {
+      exclude module: 'jline'
+      exclude module: 'netty'
+    }
     compile libs.jacksonDatabind // this dependency should be removed after KIP-4
 
     testCompile project(':clients').sourceSets.test.output
@@ -831,7 +835,10 @@ project(':connect:runtime') {
     compile libs.jettyServer
     compile libs.jettyServlet
     compile libs.jettyServlets
-    compile libs.reflections
+    compile(libs.reflections) {
+      // Exclude because of LGPL license
+      exclude group: 'com.google.code.findbugs', module: 'annotations'
+    }
 
     testCompile project(':clients').sourceSets.test.output
     testCompile libs.easymock


Mime
View raw message