kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject kafka git commit: MINOR: Double timeout passed to `producer.close` in `sendAndVerifyTimestamp`
Date Wed, 11 May 2016 00:30:49 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 6f1873242 -> fe0335ea1


MINOR: Double timeout passed to `producer.close` in `sendAndVerifyTimestamp`

We have had transient failures in this method when Jenkins is
overloaded.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1359 from ijuma/increase-producer-close-timeout-in-test


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/fe0335ea
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/fe0335ea
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/fe0335ea

Branch: refs/heads/trunk
Commit: fe0335ea1030ca61f38b343a67c78e6537d25717
Parents: 6f18732
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Tue May 10 17:30:36 2016 -0700
Committer: Ewen Cheslack-Postava <me@ewencp.org>
Committed: Tue May 10 17:30:36 2016 -0700

----------------------------------------------------------------------
 .../test/scala/integration/kafka/api/BaseProducerSendTest.scala    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/fe0335ea/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala b/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
index 15eeb63..9489e70 100644
--- a/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
+++ b/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
@@ -220,7 +220,7 @@ abstract class BaseProducerSendTest extends KafkaServerTestHarness {
         val record = new ProducerRecord[Array[Byte], Array[Byte]](topic, partition, baseTimestamp
+ i, "key".getBytes, "value".getBytes)
         producer.send(record, callback)
       }
-      producer.close(5000L, TimeUnit.MILLISECONDS)
+      producer.close(10000L, TimeUnit.MILLISECONDS)
       assertEquals(s"Should have offset $numRecords but only successfully sent ${callback.offset}",
numRecords, callback.offset)
     } finally {
       producer.close()


Mime
View raw message