kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gwens...@apache.org
Subject kafka git commit: KAFKA-3187: Make kafka-acls.sh help messages more generic.
Date Fri, 04 Mar 2016 01:34:42 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 5d8936544 -> d63bdc28c


KAFKA-3187: Make kafka-acls.sh help messages more generic.

Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Gwen Shapira

Closes #892 from SinghAsDev/KAFKA-3187


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/d63bdc28
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/d63bdc28
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/d63bdc28

Branch: refs/heads/trunk
Commit: d63bdc28cad57bb1cb38598c4ec5c0ef27113a8c
Parents: 5d89365
Author: Ashish Singh <asingh@cloudera.com>
Authored: Thu Mar 3 17:34:38 2016 -0800
Committer: Gwen Shapira <cshapi@gmail.com>
Committed: Thu Mar 3 17:34:38 2016 -0800

----------------------------------------------------------------------
 core/src/main/scala/kafka/admin/AclCommand.scala | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/d63bdc28/core/src/main/scala/kafka/admin/AclCommand.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/admin/AclCommand.scala b/core/src/main/scala/kafka/admin/AclCommand.scala
index 134ac38..01e95ca 100644
--- a/core/src/main/scala/kafka/admin/AclCommand.scala
+++ b/core/src/main/scala/kafka/admin/AclCommand.scala
@@ -292,7 +292,8 @@ object AclCommand {
       .defaultsTo(All.name)
 
     val allowPrincipalsOpt = parser.accepts("allow-principal", "principal is in principalType:name
format." +
-      " User:* is the wild card indicating all users.")
+      " Note that principalType must be supported by the Authorizer being used." +
+      " For example, User:* is the wild card indicating all users.")
       .withRequiredArg
       .describedAs("allow-principal")
       .ofType(classOf[String])
@@ -300,6 +301,7 @@ object AclCommand {
     val denyPrincipalsOpt = parser.accepts("deny-principal", "principal is in principalType:name
format. " +
       "By default anyone not added through --allow-principal is denied access. " +
       "You only need to use this option as negation to already allowed set. " +
+      "Note that principalType must be supported by the Authorizer being used. " +
       "For example if you wanted to allow access to all users in the system but not test-user
you can define an ACL that " +
       "allows access to User:* and specify --deny-principal=User:test@EXAMPLE.COM. " +
       "AND PLEASE REMEMBER DENY RULES TAKES PRECEDENCE OVER ALLOW RULES.")


Mime
View raw message