kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gwens...@apache.org
Subject kafka git commit: KAFKA-3198: Ticket Renewal Thread exits prematurely due to inverted c…
Date Thu, 04 Feb 2016 07:48:31 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.9.0 ca5e7f6f0 -> c1eec0d42


KAFKA-3198: Ticket Renewal Thread exits prematurely due to inverted c…

KAFKA-3198: Ticket Renewal Thread exits prematurely due to inverted comparison

The >= should be < since we are actually able to renew if the renewTill time is later
than the current ticket expiration.

Author: Adam Kunicki <adam@streamsets.com>

Reviewers: Ismael Juma, Gwen Shapira

Closes #858 from kunickiaj/KAFKA-3198

(cherry picked from commit 99956f56c9f994b4f55315559c07310b3d599d9b)
Signed-off-by: Gwen Shapira <cshapi@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/c1eec0d4
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/c1eec0d4
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/c1eec0d4

Branch: refs/heads/0.9.0
Commit: c1eec0d4212e8ed6912bee6ffc2ee440cacf99ac
Parents: ca5e7f6
Author: Adam Kunicki <adam@streamsets.com>
Authored: Wed Feb 3 23:48:17 2016 -0800
Committer: Gwen Shapira <cshapi@gmail.com>
Committed: Wed Feb 3 23:48:26 2016 -0800

----------------------------------------------------------------------
 .../main/java/org/apache/kafka/common/security/kerberos/Login.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/c1eec0d4/clients/src/main/java/org/apache/kafka/common/security/kerberos/Login.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/security/kerberos/Login.java b/clients/src/main/java/org/apache/kafka/common/security/kerberos/Login.java
index be91845..e8afbe6 100644
--- a/clients/src/main/java/org/apache/kafka/common/security/kerberos/Login.java
+++ b/clients/src/main/java/org/apache/kafka/common/security/kerberos/Login.java
@@ -151,7 +151,7 @@ public class Login {
                         nextRefresh = getRefreshTime(tgt);
                         long expiry = tgt.getEndTime().getTime();
                         Date expiryDate = new Date(expiry);
-                        if (isUsingTicketCache && tgt.getRenewTill() != null &&
tgt.getRenewTill().getTime() >= expiry) {
+                        if (isUsingTicketCache && tgt.getRenewTill() != null &&
tgt.getRenewTill().getTime() < expiry) {
                             log.error("The TGT cannot be renewed beyond the next expiry date:
{}." +
                                     "This process will not be able to authenticate new SASL
connections after that " +
                                     "time (for example, it will not be able to authenticate
a new connection with a Kafka " +


Mime
View raw message