kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: MINOR: remove unused TimeUnit from MetricConfig
Date Tue, 12 Jan 2016 02:01:02 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk e789a35d3 -> c9114488b


MINOR: remove unused TimeUnit from MetricConfig

Author: Dong Lin <lindong28@gmail.com>

Reviewers: Ismael Juma, Guozhang Wang

Closes #600 from lindong28/minor


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/c9114488
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/c9114488
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/c9114488

Branch: refs/heads/trunk
Commit: c9114488b3c266fe60cf96426bfa143b4b8109c0
Parents: e789a35
Author: Dong Lin <lindong28@gmail.com>
Authored: Mon Jan 11 18:00:57 2016 -0800
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Mon Jan 11 18:00:57 2016 -0800

----------------------------------------------------------------------
 .../org/apache/kafka/common/metrics/MetricConfig.java    | 11 -----------
 1 file changed, 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/c9114488/clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java b/clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
index 6bd351d..a423334 100644
--- a/clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
+++ b/clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
@@ -29,7 +29,6 @@ public class MetricConfig {
     private int samples;
     private long eventWindow;
     private long timeWindowMs;
-    private TimeUnit unit;
     private Map<String, String> tags;
 
     public MetricConfig() {
@@ -38,7 +37,6 @@ public class MetricConfig {
         this.samples = 2;
         this.eventWindow = Long.MAX_VALUE;
         this.timeWindowMs = TimeUnit.MILLISECONDS.convert(30, TimeUnit.SECONDS);
-        this.unit = TimeUnit.SECONDS;
         this.tags = new LinkedHashMap<>();
     }
 
@@ -88,13 +86,4 @@ public class MetricConfig {
         this.samples = samples;
         return this;
     }
-
-    public TimeUnit timeUnit() {
-        return unit;
-    }
-
-    public MetricConfig timeUnit(TimeUnit unit) {
-        this.unit = unit;
-        return this;
-    }
 }


Mime
View raw message