kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject kafka git commit: MINOR: Remove `InvalidReceiveException` catch in `SocketServer`
Date Thu, 12 Nov 2015 15:19:07 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 3fd168d95 -> b5401f291


MINOR: Remove `InvalidReceiveException` catch in `SocketServer`

`Selector.poll` no longer throws it.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #506 from ijuma/poll-no-longer-throws-invalid-receive-exception


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/b5401f29
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/b5401f29
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/b5401f29

Branch: refs/heads/trunk
Commit: b5401f291a16977992c50f0a66d9f02aea07bbe7
Parents: 3fd168d
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Thu Nov 12 07:19:02 2015 -0800
Committer: Jun Rao <junrao@gmail.com>
Committed: Thu Nov 12 07:19:02 2015 -0800

----------------------------------------------------------------------
 core/src/main/scala/kafka/network/SocketServer.scala | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/b5401f29/core/src/main/scala/kafka/network/SocketServer.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/network/SocketServer.scala b/core/src/main/scala/kafka/network/SocketServer.scala
index 1b94c86..cb38153 100644
--- a/core/src/main/scala/kafka/network/SocketServer.scala
+++ b/core/src/main/scala/kafka/network/SocketServer.scala
@@ -33,7 +33,7 @@ import kafka.server.KafkaConfig
 import kafka.utils._
 import org.apache.kafka.common.MetricName
 import org.apache.kafka.common.metrics._
-import org.apache.kafka.common.network.{Selector => KSelector, LoginType, Mode, ChannelBuilders,
InvalidReceiveException}
+import org.apache.kafka.common.network.{Selector => KSelector, LoginType, Mode, ChannelBuilders}
 import org.apache.kafka.common.security.auth.KafkaPrincipal
 import org.apache.kafka.common.protocol.SecurityProtocol
 import org.apache.kafka.common.protocol.types.SchemaException
@@ -417,9 +417,6 @@ private[kafka] class Processor(val id: Int,
             swallow(closeAll())
             shutdownComplete()
             throw e
-          case e: InvalidReceiveException =>
-            // Log warning and continue since Selector already closed the connection
-            warn("Connection was closed due to invalid receive. Processor will continue handling
other connections")
         }
         selector.completedReceives.asScala.foreach { receive =>
           try {


Mime
View raw message