kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: [MINOR] fix new consumer heartbeat reschedule bug
Date Thu, 16 Jul 2015 02:00:47 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 4fcb7acaf -> 83d17e5b2


[MINOR] fix new consumer heartbeat reschedule bug

This commit fixes a minor issue introduced in the patch for KAFKA-2123. The schedule method
requires the time the task should be executed, not a delay.

Author: Jason Gustafson <jason@confluent.io>

Closes #79 from hachikuji/KAFKA-2123-fix and squashes the following commits:

6eb7ec6 [Jason Gustafson] [Minor] fix new consumer heartbeat reschedule bug


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/83d17e5b
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/83d17e5b
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/83d17e5b

Branch: refs/heads/trunk
Commit: 83d17e5b2403a4916d51ab69825ea657f8c802a7
Parents: 4fcb7ac
Author: Jason Gustafson <jason@confluent.io>
Authored: Wed Jul 15 19:00:37 2015 -0700
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Wed Jul 15 19:00:37 2015 -0700

----------------------------------------------------------------------
 .../org/apache/kafka/clients/consumer/internals/Coordinator.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/83d17e5b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
index 8e3cd09..6026b23 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
@@ -272,7 +272,7 @@ public final class Coordinator {
 
                     @Override
                     public void onFailure(RuntimeException e) {
-                        client.schedule(HeartbeatTask.this, retryBackoffMs);
+                        client.schedule(HeartbeatTask.this, time.milliseconds() + retryBackoffMs);
                     }
                 });
             }


Mime
View raw message