From commits-return-2339-apmail-kafka-commits-archive=kafka.apache.org@kafka.apache.org Mon Apr 20 16:28:13 2015 Return-Path: X-Original-To: apmail-kafka-commits-archive@www.apache.org Delivered-To: apmail-kafka-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 52C1E178A6 for ; Mon, 20 Apr 2015 16:28:13 +0000 (UTC) Received: (qmail 58894 invoked by uid 500); 20 Apr 2015 16:28:10 -0000 Delivered-To: apmail-kafka-commits-archive@kafka.apache.org Received: (qmail 58873 invoked by uid 500); 20 Apr 2015 16:28:10 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 58864 invoked by uid 99); 20 Apr 2015 16:28:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Apr 2015 16:28:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E567BE0922; Mon, 20 Apr 2015 16:28:09 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: nehanarkhede@apache.org To: commits@kafka.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: kafka git commit: TopicConfigManager javadoc references incorrect paths; reviewed by Neha Narkhede Date: Mon, 20 Apr 2015 16:28:09 +0000 (UTC) Repository: kafka Updated Branches: refs/heads/trunk 3139cc31f -> ed11e177d TopicConfigManager javadoc references incorrect paths; reviewed by Neha Narkhede Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/ed11e177 Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/ed11e177 Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/ed11e177 Branch: refs/heads/trunk Commit: ed11e177d4144a3a803b60f9040ee1bfc17b3b50 Parents: 3139cc3 Author: Aditya Auradkar Authored: Mon Apr 20 09:27:56 2015 -0700 Committer: Neha Narkhede Committed: Mon Apr 20 09:28:05 2015 -0700 ---------------------------------------------------------------------- core/src/main/scala/kafka/server/TopicConfigManager.scala | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/ed11e177/core/src/main/scala/kafka/server/TopicConfigManager.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/kafka/server/TopicConfigManager.scala b/core/src/main/scala/kafka/server/TopicConfigManager.scala index 47295d4..b675a7e 100644 --- a/core/src/main/scala/kafka/server/TopicConfigManager.scala +++ b/core/src/main/scala/kafka/server/TopicConfigManager.scala @@ -30,17 +30,17 @@ import org.I0Itec.zkclient.{IZkChildListener, ZkClient} * It works as follows. * * Config is stored under the path - * /brokers/topics//config + * /config/topics/ * This znode stores the topic-overrides for this topic (but no defaults) in properties format. * * To avoid watching all topics for changes instead we have a notification path - * /brokers/config_changes + * /config/changes * The TopicConfigManager has a child watch on this path. * * To update a topic config we first update the topic config properties. Then we create a new sequential * znode under the change path which contains the name of the topic that was updated, say - * /brokers/config_changes/config_change_13321 - * This is just a notification--the actual config change is stored only once under the /brokers/topics//config path. + * /config/changes/config_change_13321 + * This is just a notification--the actual config change is stored only once under the /config/topics/ path. * * This will fire a watcher on all brokers. This watcher works as follows. It reads all the config change notifications. * It keeps track of the highest config change suffix number it has applied previously. For any previously applied change it finds