kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nehanarkh...@apache.org
Subject [1/2] KAFKA-1725 Configuration file bugs in system tests add noise to output and break a few tests; reviewed by Neha Narkhede
Date Fri, 24 Oct 2014 16:06:29 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.8.2 c2dadda3a -> caf4787e5


http://git-wip-us.apache.org/repos/asf/kafka/blob/caf4787e/system_test/replication_testsuite/testcase_10134/testcase_0134_properties.json
----------------------------------------------------------------------
diff --git a/system_test/replication_testsuite/testcase_10134/testcase_0134_properties.json
b/system_test/replication_testsuite/testcase_10134/testcase_0134_properties.json
deleted file mode 100644
index 73bb859..0000000
--- a/system_test/replication_testsuite/testcase_10134/testcase_0134_properties.json
+++ /dev/null
@@ -1,92 +0,0 @@
-{
-  "description": {"01":"Leader Failure in Replication with multi topics & partitions
: 1. auto_create_topic => true",
-                  "02":"Produce and consume messages to 2 topics - 3 partitions",
-                  "03":"This test sends messages to 2 replicas",
-                  "04":"To trigger leader election: find the leader and terminate by controlled
failure (kill -15)",
-                  "05":"Restart the terminated broker",
-                  "06":"Lookup brokers' log4j messages and verify that leader is re-elected
successfully",
-                  "07":"At the end it verifies the log size and contents",
-                  "08":"Use a consumer to verify no message loss.",
-                  "09":"Producer dimensions : mode:sync, acks:-1, comp:0",
-                  "10":"Log segment size    : 102400"
-  },
-  "testcase_args": {
-    "broker_type": "leader",
-    "bounce_broker": "true",
-    "replica_factor": "2",
-    "num_partition": "3",
-    "num_iteration": "3",
-    "auto_create_topic": "true",
-    "producer_multi_topics_mode": "true",
-    "consumer_multi_topics_mode": "true",
-    "sleep_seconds_between_producer_calls": "1",
-    "message_producing_free_time_sec": "15"
-  },
-  "entities": [
-    {
-      "entity_id": "0",
-      "clientPort": "2188",
-      "dataDir": "/tmp/zookeeper_0",
-      "log_filename": "zookeeper_2188.log",
-      "config_filename": "zookeeper_2188.properties"
-    },
-    {
-      "entity_id": "1",
-      "port": "9091",
-      "broker.id": "1",
-      "num.partitions": "3",
-      "default.replication.factor": "2",
-      "log.segment.bytes": "102400",
-      "log.dir": "/tmp/kafka_server_1_logs",
-      "log.index.interval.bytes": "10",
-      "log_filename": "kafka_server_9091.log",
-      "config_filename": "kafka_server_9091.properties"
-    },
-    {
-      "entity_id": "2",
-      "port": "9092",
-      "broker.id": "2",
-      "num.partitions": "3",
-      "default.replication.factor": "2",
-      "log.segment.bytes": "102400",
-      "log.dir": "/tmp/kafka_server_2_logs",
-      "log.index.interval.bytes": "10",
-      "log_filename": "kafka_server_9092.log",
-      "config_filename": "kafka_server_9092.properties"
-    },
-    {
-      "entity_id": "3",
-      "port": "9093",
-      "broker.id": "3",
-      "num.partitions": "3",
-      "default.replication.factor": "2",
-      "log.segment.bytes": "102400",
-      "log.dir": "/tmp/kafka_server_3_logs",
-      "log.index.interval.bytes": "10",
-      "log_filename": "kafka_server_9093.log",
-      "config_filename": "kafka_server_9093.properties"
-    },
-    {
-      "entity_id": "4",
-      "topic": "test_1,test_2",
-      "threads": "5",
-      "compression-codec": "1",
-      "message-size": "500",
-      "message": "100",
-      "request-num-acks": "-1",
-      "producer-retry-backoff-ms": "3500",
-      "producer-num-retries": "3",
-      "sync":"false",
-      "log_filename": "producer_performance_4.log",
-      "config_filename": "producer_performance_4.properties"
-    },
-    {
-      "entity_id": "5",
-      "topic": "test_1,test_2",
-      "groupid": "mytestgroup",
-      "consumer-timeout-ms": "10000",
-      "log_filename": "console_consumer_5.log",
-      "config_filename": "console_consumer_5.properties"
-    }
-  ]
-}

http://git-wip-us.apache.org/repos/asf/kafka/blob/caf4787e/system_test/utils/metrics.py
----------------------------------------------------------------------
diff --git a/system_test/utils/metrics.py b/system_test/utils/metrics.py
index d98d3cd..3e66348 100644
--- a/system_test/utils/metrics.py
+++ b/system_test/utils/metrics.py
@@ -106,6 +106,8 @@ def ensure_valid_headers(headers, attributes):
                         " headers: {0}".format(",".join(headers)))
         
 def plot_graphs(inputCsvFiles, labels, title, xLabel, yLabel, attribute, outputGraphFile):
+    if not inputCsvFiles: return
+
     # create empty plot
     fig=plt.figure()
     fig.subplots_adjust(bottom=0.2)


Mime
View raw message