kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject git commit: kafka-1084; Validate properties for custom serializers; patched by Francois Saint-Jacquese; reviewed by Jun Rao
Date Tue, 15 Oct 2013 16:47:56 GMT
Updated Branches:
  refs/heads/trunk 062d910e3 -> e351039b1


kafka-1084; Validate properties for custom serializers; patched by Francois Saint-Jacquese;
reviewed by Jun Rao


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/e351039b
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/e351039b
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/e351039b

Branch: refs/heads/trunk
Commit: e351039b1a9ed188e3be1581f31674b876094274
Parents: 062d910
Author: Francois Saint-Jacques <fsaintjacques@gmail.com>
Authored: Tue Oct 15 09:47:40 2013 -0700
Committer: Jun Rao <junrao@gmail.com>
Committed: Tue Oct 15 09:47:40 2013 -0700

----------------------------------------------------------------------
 core/src/main/scala/kafka/utils/VerifiableProperties.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/e351039b/core/src/main/scala/kafka/utils/VerifiableProperties.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/utils/VerifiableProperties.scala b/core/src/main/scala/kafka/utils/VerifiableProperties.scala
index a288ad5..b070bb4 100644
--- a/core/src/main/scala/kafka/utils/VerifiableProperties.scala
+++ b/core/src/main/scala/kafka/utils/VerifiableProperties.scala
@@ -200,7 +200,7 @@ class VerifiableProperties(val props: Properties) extends Logging {
       Collections.list(props.propertyNames).map(_.toString).sorted
     }
     for(key <- propNames) {
-      if (!referenceSet.contains(key))
+      if (!referenceSet.contains(key) && !key.startsWith("external"))
         warn("Property %s is not valid".format(key))
       else
         info("Property %s is overridden to %s".format(key, props.getProperty(key)))


Mime
View raw message