kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject git commit: kafka-919; Disabling of auto commit is ignored during consumer group rebalancing; patched by Phil Hargett; reviewed by Jun Rao
Date Sat, 25 May 2013 05:01:19 GMT
Updated Branches:
  refs/heads/0.8 ffd84eb23 -> 59599cc12


kafka-919; Disabling of auto commit is ignored during consumer group rebalancing; patched
by Phil Hargett; reviewed by Jun Rao


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/59599cc1
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/59599cc1
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/59599cc1

Branch: refs/heads/0.8
Commit: 59599cc127f32e17b07092a6c59fce742d027c47
Parents: ffd84eb
Author: Phil Hargett <phil.hargett@mirror-images.com>
Authored: Fri May 24 22:00:57 2013 -0700
Committer: Jun Rao <junrao@gmail.com>
Committed: Fri May 24 22:00:57 2013 -0700

----------------------------------------------------------------------
 .../consumer/ZookeeperConsumerConnector.scala      |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/59599cc1/core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala b/core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
index e66680b..d952187 100644
--- a/core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
+++ b/core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
@@ -496,6 +496,7 @@ private[kafka] class ZookeeperConsumerConnector(val config: ConsumerConfig,
           * by the consumer, there will be no more messages returned by this iterator until
the rebalancing finishes
           * successfully and the fetchers restart to fetch more data chunks
           **/
+        if (config.autoCommitEnable)
           commitOffsets
         case None =>
       }


Mime
View raw message