kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject [20/37] git commit: KAFKA-770 KafkaConfig properties should be verified in the constructor; reviewed by Neha Narkhede
Date Mon, 04 Mar 2013 04:22:01 GMT
KAFKA-770 KafkaConfig properties should be verified in the constructor; reviewed by Neha Narkhede


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/b056a9a1
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/b056a9a1
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/b056a9a1

Branch: refs/heads/trunk
Commit: b056a9a1eca8fb27812c7e4bc5872a9d96aae866
Parents: 049ac88
Author: Swapnil Ghike <sghike@linkedin.com>
Authored: Fri Feb 22 08:13:31 2013 -0800
Committer: Neha Narkhede <neha.narkhede@gmail.com>
Committed: Fri Feb 22 08:13:32 2013 -0800

----------------------------------------------------------------------
 core/src/main/scala/kafka/server/KafkaConfig.scala |    3 +--
 .../scala/kafka/server/KafkaServerStartable.scala  |    1 -
 2 files changed, 1 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/b056a9a1/core/src/main/scala/kafka/server/KafkaConfig.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala b/core/src/main/scala/kafka/server/KafkaConfig.scala
index f65db33..b8970c8 100644
--- a/core/src/main/scala/kafka/server/KafkaConfig.scala
+++ b/core/src/main/scala/kafka/server/KafkaConfig.scala
@@ -29,10 +29,9 @@ class KafkaConfig private (val props: VerifiableProperties) extends ZKConfig(pro
 
   def this(originalProps: Properties) {
     this(new VerifiableProperties(originalProps))
+    props.verify()
   }
 
-  def verify() = props.verify()
-  
   /*********** General Configuration ***********/
   
   /* the broker id for this server */

http://git-wip-us.apache.org/repos/asf/kafka/blob/b056a9a1/core/src/main/scala/kafka/server/KafkaServerStartable.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/server/KafkaServerStartable.scala b/core/src/main/scala/kafka/server/KafkaServerStartable.scala
index 14fb7fc..5be65e9 100644
--- a/core/src/main/scala/kafka/server/KafkaServerStartable.scala
+++ b/core/src/main/scala/kafka/server/KafkaServerStartable.scala
@@ -32,7 +32,6 @@ class KafkaServerStartable(val serverConfig: KafkaConfig) extends Logging
{
   def startup() {
     try {
       server.startup()
-      serverConfig.verify()
     }
     catch {
       case e =>


Mime
View raw message