kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject svn commit: r1226599 - in /incubator/kafka/trunk/core/src/main/scala/kafka: producer/SyncProducer.scala server/KafkaServerStartable.scala utils/Utils.scala
Date Tue, 03 Jan 2012 01:55:24 GMT
Author: junrao
Date: Tue Jan  3 01:55:23 2012
New Revision: 1226599

URL: http://svn.apache.org/viewvc?rev=1226599&view=rev
Log:
avoid logging stacktrace directly; patched by Jun Rao; reviewed by Neha Narkhede; KAFKA-231

Modified:
    incubator/kafka/trunk/core/src/main/scala/kafka/producer/SyncProducer.scala
    incubator/kafka/trunk/core/src/main/scala/kafka/server/KafkaServerStartable.scala
    incubator/kafka/trunk/core/src/main/scala/kafka/utils/Utils.scala

Modified: incubator/kafka/trunk/core/src/main/scala/kafka/producer/SyncProducer.scala
URL: http://svn.apache.org/viewvc/incubator/kafka/trunk/core/src/main/scala/kafka/producer/SyncProducer.scala?rev=1226599&r1=1226598&r2=1226599&view=diff
==============================================================================
--- incubator/kafka/trunk/core/src/main/scala/kafka/producer/SyncProducer.scala (original)
+++ incubator/kafka/trunk/core/src/main/scala/kafka/producer/SyncProducer.scala Tue Jan  3
01:55:23 2012
@@ -61,13 +61,13 @@ class SyncProducer(val config: SyncProdu
             }
             catch {
               case e: Throwable =>
-              trace("error iterating messages " + e + Utils.stackTrace(e))
+                trace("error iterating messages ", e)
             }
           }
         }
         catch {
           case e: Throwable =>
-            trace("error verifying sendbuffer " + e + Utils.stackTrace(e))
+            trace("error verifying sendbuffer ", e)
         }
       }
     }

Modified: incubator/kafka/trunk/core/src/main/scala/kafka/server/KafkaServerStartable.scala
URL: http://svn.apache.org/viewvc/incubator/kafka/trunk/core/src/main/scala/kafka/server/KafkaServerStartable.scala?rev=1226599&r1=1226598&r2=1226599&view=diff
==============================================================================
--- incubator/kafka/trunk/core/src/main/scala/kafka/server/KafkaServerStartable.scala (original)
+++ incubator/kafka/trunk/core/src/main/scala/kafka/server/KafkaServerStartable.scala Tue
Jan  3 01:55:23 2012
@@ -203,8 +203,7 @@ class EmbeddedConsumer(private val consu
       }
       catch {
         case e =>
-          fatal(e + Utils.stackTrace(e))
-          fatal(topic + " stream " + threadId + " unexpectedly exited")
+          fatal(topic + " stream " + threadId + " unexpectedly exited", e)
       }finally {
         shutdownComplete.countDown
         info("Stopped mirroring thread %s for topic %s and stream %d".format(name, topic,
threadId))

Modified: incubator/kafka/trunk/core/src/main/scala/kafka/utils/Utils.scala
URL: http://svn.apache.org/viewvc/incubator/kafka/trunk/core/src/main/scala/kafka/utils/Utils.scala?rev=1226599&r1=1226598&r2=1226599&view=diff
==============================================================================
--- incubator/kafka/trunk/core/src/main/scala/kafka/utils/Utils.scala (original)
+++ incubator/kafka/trunk/core/src/main/scala/kafka/utils/Utils.scala Tue Jan  3 01:55:23
2012
@@ -60,8 +60,7 @@ object Utils extends Logging {
         catch {
           case t =>
             // log any error and the stack trace
-            error(t)
-            error(stackTrace(t), t)
+            error("error in loggedRunnable", t)
         }
       }
     }



Mime
View raw message