juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Bognar <jamesbog...@apache.org>
Subject Re: [GitHub] [juneau-petstore] ishita20 opened a new pull request #2: JUNEAU-152 Added a Dockerfile to run app using war file
Date Sun, 13 Oct 2019 22:19:59 GMT
I've merged the change.  Looks good!

I suggest we update the documentation found here:
http://juneau.apache.org/index.html#petstore.html

The source for this can be found in the following repo:
https://github.com/apache/juneau-website
The file is juneau-website/content/petstore.html.

On Sun, Oct 13, 2019 at 9:28 AM Ishita Singh <ishitasingh1234@gmail.com> wrote:
>
> Hi,
>
> Do I need to make any changes? I shall start with the documentation once this is finalized.
>
> Thanks.
>
> ---------- Forwarded message ---------
> From: GitBox <git@apache.org>
> Date: Sat 12 Oct, 2019, 2:33 PM
> Subject: [GitHub] [juneau-petstore] ishita20 opened a new pull request #2: JUNEAU-152
Added a Dockerfile to run app using war file
> To: <dev@juneau.apache.org>
>
>
> ishita20 opened a new pull request #2: JUNEAU-152 Added a Dockerfile to run app using
war file
> URL: https://github.com/apache/juneau-petstore/pull/2
>
>
>    The current Dockerfile has steps to only run the war file. Should I also add steps
to build the app and use the war file from this build itself?
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services

Mime
View raw message