juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JUNEAU-93) Use constructor argument names as bean property names.
Date Sun, 02 Dec 2018 17:00:00 GMT

    [ https://issues.apache.org/jira/browse/JUNEAU-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706402#comment-16706402
] 

ASF GitHub Bot commented on JUNEAU-93:
--------------------------------------

jamesbognar closed pull request #25: [JUNEAU-93] Use constructor argument names as bean property
names.
URL: https://github.com/apache/juneau/pull/25
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/annotation/BeanProperty.java
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/annotation/BeanProperty.java
index 446717727..84a5b9d3c 100644
--- a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/annotation/BeanProperty.java
+++ b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/annotation/BeanProperty.java
@@ -31,7 +31,7 @@
  * </ul>
  */
 @Documented
-@Target({FIELD,METHOD})
+@Target({FIELD,METHOD,PARAMETER})
 @Retention(RUNTIME)
 @Inherited
 public @interface BeanProperty {
diff --git a/pom.xml b/pom.xml
index 50cb30bb9..91df359de 100644
--- a/pom.xml
+++ b/pom.xml
@@ -255,6 +255,8 @@
 					<configuration>
 						<source>1.8</source>
 						<target>1.8</target>
+						<compilerArgument>-parameters</compilerArgument>
+      						<testCompilerArgument>-parameters</testCompilerArgument>
 					</configuration>
 				</plugin>
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use constructor argument names as bean property names.
> ------------------------------------------------------
>
>                 Key: JUNEAU-93
>                 URL: https://issues.apache.org/jira/browse/JUNEAU-93
>             Project: Juneau
>          Issue Type: Improvement
>          Components: Code
>    Affects Versions: 7.2.2
>            Reporter: James Bognar
>            Priority: Major
>
> Java 8 added a feature to persist method argument names in bytecode so that they are
available through reflection.  It's an optional compile-time flag that's disabled by default. 
Since it's disabled by default, we cannot rely on it for bean property names.  However, if
the feature is enabled, we can make the @BeanConstructor(properties) annotation optional.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message