On Sat, Oct 27, 2018, 5:16 AM David Goddard <dmg@parse.net> wrote:

+1 (binding) from me. Thank you.

David

On 26/10/2018 20:36, James Bognar wrote:
> Reminder that's it's been over 72 hours and we are still in need for 2
> positive votes to proceed.
>
> The plan for the minor issues discovered so far is to release them
> quickly in a 7.2.2 release in the next week or so. Then in about a
> month we can start cleaning up deprecated classes for a release 8.0.
>
> On Thu, Oct 25, 2018 at 5:05 PM James Bognar <jamesbognar@apache.org
> <mailto:jamesbognar@apache.org>> wrote:
>
> I think I see the problem. For the HTML parser, we're getting the
> position from the javax.xml.stream.XMLStreamReader class.
> Apparently the IBM implementation of XMLStreamReader.getLocation()
> is not implemented.
>
> I'll have to loosen the test.
>
> On Thu, Oct 25, 2018 at 1:12 PM David Goddard <goddard@acm.org
> <mailto:goddard@acm.org>> wrote:
>
> Hi,
>
> I have a familiar issue with this build in that it fails on my
> Windows
> environment but works fine on my Mac.
>
> Here is the Windows output:
>
> ####################################
>
> [INFO] Running org.apache.juneau.html.CommonParserTest
> [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed:
> 0.016 s <<< FAILURE! - in org.apache.juneau.html.CommonParserTest
> [ERROR]
> testParserListeners(org.apache.juneau.html.CommonParserTest)
> Time elapsed: 0.016 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<unknown, [line 1, column
> 196]>
> but was:<unknown, [unknown]>
> at
> org.apache.juneau.html.CommonParserTest.testParserListeners(CommonParserTest.java:150)
>
> ####################################
>
> [ERROR] Failures:
> [ERROR] CommonParserTest.testParserListeners:150
> expected:<unknown,
> [line 1, column 196]> but was:<unknown, [unknown]>
> [INFO]
> [ERROR] Tests run: 18397, Failures: 1, Errors: 0, Skipped: 1
> [INFO]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Juneau ......................................
> SUCCESS [
> 13.169 s]
> [INFO] Apache Juneau - Core APIs ..........................
> SUCCESS [
> 0.390 s]
> [INFO] Apache Juneau Marshall .............................
> SUCCESS [
> 21.561 s]
> [INFO] Apache Juneau Marshal RDF ..........................
> SUCCESS [
> 2.060 s]
> [INFO] Apache Juneau Data Transfer Objects ................
> SUCCESS [
> 3.593 s]
> [INFO] Apache Juneau Core .................................
> SUCCESS [
> 1.297 s]
> [INFO] Apache Juneau Config File API ......................
> SUCCESS [
> 1.358 s]
> [INFO] Apache Juneau Core Tests ...........................
> FAILURE [
> 25.280 s]
> [INFO] Apache Juneau - REST APIs .......................... SKIPPED
> [INFO] Apache Juneau REST Servlet API ..................... SKIPPED
> [INFO] Apache Juneau REST JAX/RS API ...................... SKIPPED
> [INFO] Apache Juneau REST Client API ...................... SKIPPED
> [INFO] Apache Juneau - Microservice APIs .................. SKIPPED
> [INFO] Apache Juneau Microservice Server .................. SKIPPED
> [INFO] Apache Juneau Microservice Template ................ SKIPPED
> [INFO] Apache Juneau - Examples ........................... SKIPPED
> [INFO] Apache Juneau REST Examples ........................ SKIPPED
> [INFO] Apache Juneau Microservice Tests ................... SKIPPED
> [INFO] Apache Juneau Core Examples ........................ SKIPPED
> [INFO] Apache Juneau Javadocs ............................. SKIPPED
> [INFO] Apache Juneau - Release Engineering ................ SKIPPED
> [INFO] Apache Juneau UberJar .............................. SKIPPED
> [INFO] Apache Juneau Distribution ......................... SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 01:10 min
> [INFO] Finished at: 2018-10-25T17:40:33+02:00
> [INFO] Final Memory: 97M/227M
> [INFO]
> ------------------------------------------------------------------------
>
> ####################################
>
> Meanwhile Mac is fine:
>
> ####################################
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Juneau 7.2.1 ................................
> SUCCESS [
> 1.489 s]
> [INFO] Apache Juneau - Core APIs ..........................
> SUCCESS [
> 0.126 s]
> [INFO] Apache Juneau Marshall .............................
> SUCCESS [
> 14.609 s]
> [INFO] Apache Juneau Marshal RDF ..........................
> SUCCESS [
> 1.092 s]
> [INFO] Apache Juneau Data Transfer Objects ................
> SUCCESS [
> 2.141 s]
> [INFO] Apache Juneau Core .................................
> SUCCESS [
> 0.349 s]
> [INFO] Apache Juneau Config File API ......................
> SUCCESS [
> 0.579 s]
> [INFO] Apache Juneau Core Tests ...........................
> SUCCESS [
> 20.637 s]
> [INFO] Apache Juneau - REST APIs ..........................
> SUCCESS [
> 0.065 s]
> [INFO] Apache Juneau REST Servlet API .....................
> SUCCESS [
> 7.856 s]
> [INFO] Apache Juneau REST JAX/RS API ......................
> SUCCESS [
> 0.317 s]
> [INFO] Apache Juneau REST Client API ......................
> SUCCESS [
> 3.201 s]
> [INFO] Apache Juneau - Microservice APIs ..................
> SUCCESS [
> 0.037 s]
> [INFO] Apache Juneau Microservice Server ..................
> SUCCESS [
> 1.116 s]
> [INFO] Apache Juneau Microservice Template ................
> SUCCESS [
> 0.620 s]
> [INFO] Apache Juneau - Examples ...........................
> SUCCESS [
> 0.043 s]
> [INFO] Apache Juneau REST Examples ........................
> SUCCESS [
> 37.143 s]
> [INFO] Apache Juneau Microservice Tests ...................
> SUCCESS [
> 12.358 s]
> [INFO] Apache Juneau Core Examples ........................
> SUCCESS [
> 0.140 s]
> [INFO] Apache Juneau Javadocs .............................
> SUCCESS [
> 2.016 s]
> [INFO] Apache Juneau - Release Engineering ................
> SUCCESS [
> 0.027 s]
> [INFO] Apache Juneau UberJar ..............................
> SUCCESS [
> 0.672 s]
> [INFO] Apache Juneau Distribution 7.2.1 ...................
> SUCCESS [
> 0.595 s]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 01:47 min
> [INFO] Finished at: 2018-10-25T18:21:38+02:00
> [INFO]
> ------------------------------------------------------------------------
>
> ####################################
>
> Here is the failing test code in CommonParserTest:
>
> @Test
> public void testParserListeners() throws Exception {
> HtmlParser p =
> HtmlParser.create().ignoreUnknownBeanProperties().listener(MyParserListener.class).build();
>
> String in = "<table
> _type='object'><tr><th><string>key</string></th><th><string>value</string></th></tr><tr><td><string>a</string></td><td><number>1</number></td></tr><tr><td><string>unknown</string></td><td><string>/foo</string></td></tr><tr><td><string>b</string></td><td><number>2</number></td></tr></table>";
> p.parse(in, B.class);
> assertEquals(1, MyParserListener.events.size());
> assertEquals("unknown, line 1, column 196",
> MyParserListener.events.get(0));
> }
>
>
> Specifically line 150:
> assertEquals("unknown, line 1, column 196",
> MyParserListener.events.get(0));
>
> Not had a chance to run through in debug yet. Given the often
> problematic nature of my IBM JRE in my Windows environment
> (currently
> build 8.0.5.17 - pwa6480sr5fp17-20180627_01(SR5 FP17)), I'm not
> overly
> concerned about this as a blocking issue for release from my
> personal
> perspective.
>
> David
> (sorry, have been out of the loop for a while, catching up)
>
>
> On 23/10/2018 15:34, James Bognar wrote:
> > I am pleased to be calling this vote for the source release
> of Apache
> > Juneau 7.2.1 RC1.
> >
> > The binaries are available at:
> >
> https://dist.apache.org/repos/dist/dev/juneau/binaries/juneau-7.2.1-RC1/
> >
> > The release candidate to be voted over is available at:
> >
> https://dist.apache.org/repos/dist/dev/juneau/source/juneau-7.2.1-RC1/
> >
> > MD5 checksums:
> > apache-juneau-7.2.1-src.zip: 9646c6a22349d6e3fd19efd3526087aa
> > apache-juneau-7.2.1-bin.zip: ee94aa3273557ee588a18fb1df49952a
> >
> > SHA-512 checksums:
> > apache-juneau-7.2.1-bin.zip: 102C98D9 15EFF241 67A2CA0A
> A3FB3ABC 4B91D8CB
> > 795083E9 BF054C8F CE7380A5
> FA8C20FE 744EC263
> > C5DA1C1A 05F5D001 D335A89E
> 916F89C5 CCD3011F
> > 7A048160
> > apache-juneau-7.2.1-src.zip: 9EE3BA64 876B7920 3A8D0316
> 91510C99 0F4BF7B5
> > 26A5872A 5BB74022 E2585A9C
> 4652E487 1A0F6014
> > 142E1C88 C1E579CE A77DAB13
> 545B7DA0 2134418F
> > 3B22DD14
> >
> > Build the release candidate using:
> > mvn clean install
> >
> > The release candidate is signed with a GPG key available at:
> > https://dist.apache.org/repos/dist/release/juneau/KEYS
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachejuneau-1024/
> >
> > The Git commit for this release is...
> >
> https://gitbox.apache.org/repos/asf?p=juneau.git;a=commit;h=0c06d4c11f480e21d5d983346bd556ab82540a60
> >
> > Please vote on releasing this package as:
> > Apache Juneau 7.2.1
> >
> > This vote will be open until 26-Oct-2018 9:30am and passes if
> a majority
> > of at least three +1 Apache Juneau PMC votes are cast.
> >
> > [ ] +1 Release this package
> > [ ] 0 I don't feel strongly about it, but don't object
> > [ ] -1 Do not release this package because...
> >
> > Anyone can participate in testing and voting, not just
> committers,
> > please feel free to try out the release candidate and provide
> your votes.
>