juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JUNEAU-87) Tests should not use hard-wired line-endings.
Date Tue, 16 Oct 2018 19:45:00 GMT

    [ https://issues.apache.org/jira/browse/JUNEAU-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652337#comment-16652337
] 

ASF GitHub Bot commented on JUNEAU-87:
--------------------------------------

jamesbognar closed pull request #8: [JUNEAU-87] Tests should not use hard-wired line-endings.
URL: https://github.com/apache/juneau/pull/8
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/juneau-core/juneau-core-test/src/test/java/org/apache/juneau/marshall/N3Test.java
b/juneau-core/juneau-core-test/src/test/java/org/apache/juneau/marshall/N3Test.java
index efd9cc2b3..813e33710 100644
--- a/juneau-core/juneau-core-test/src/test/java/org/apache/juneau/marshall/N3Test.java
+++ b/juneau-core/juneau-core-test/src/test/java/org/apache/juneau/marshall/N3Test.java
@@ -20,13 +20,15 @@
 
 public class N3Test {
 
+	private static String EOL = System.getProperty("line.separator");
+
 	CharMarshall m = N3.DEFAULT;
 
 	String r = ""
-		+ "@prefix jp:      <http://www.apache.org/juneaubp/> .\n"
-		+ "@prefix j:       <http://www.apache.org/juneau/> .\n"
-		+ "\n"
-		+ "[]    j:value \"foo\" .\n";
+		+ "@prefix jp:      <http://www.apache.org/juneaubp/> ." + EOL
+		+ "@prefix j:       <http://www.apache.org/juneau/> ." + EOL
+		+ EOL
+		+ "[]    j:value \"foo\" ." + EOL;
 
 	@Test
 	public void write1() throws Exception {
diff --git a/juneau-core/juneau-core-test/src/test/java/org/apache/juneau/marshall/TurtleTest.java
b/juneau-core/juneau-core-test/src/test/java/org/apache/juneau/marshall/TurtleTest.java
index a3bfdb875..72d8e09ed 100644
--- a/juneau-core/juneau-core-test/src/test/java/org/apache/juneau/marshall/TurtleTest.java
+++ b/juneau-core/juneau-core-test/src/test/java/org/apache/juneau/marshall/TurtleTest.java
@@ -20,13 +20,15 @@
 
 public class TurtleTest {
 
+	private static String EOL = System.getProperty("line.separator");
+
 	CharMarshall m = Turtle.DEFAULT;
 
 	String r = ""
-		+ "@prefix jp:      <http://www.apache.org/juneaubp/> .\n"
-		+ "@prefix j:       <http://www.apache.org/juneau/> .\n"
-		+ "\n"
-		+ "[]    j:value \"foo\" .\n";
+		+ "@prefix jp:      <http://www.apache.org/juneaubp/> ." + EOL
+		+ "@prefix j:       <http://www.apache.org/juneau/> ." + EOL
+		+ EOL
+		+ "[]    j:value \"foo\" ." + EOL;
 
 	@Test
 	public void write1() throws Exception {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Tests should not use hard-wired line-endings.
> ---------------------------------------------
>
>                 Key: JUNEAU-87
>                 URL: https://issues.apache.org/jira/browse/JUNEAU-87
>             Project: Juneau
>          Issue Type: Bug
>          Components: Code
>            Reporter: Gary Gregory
>            Priority: Major
>
> Tests should not use hard-wired line-endings. 
> Please see https://github.com/apache/juneau/pull/8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message