juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Goddard <godd...@acm.org>
Subject Re: [VOTE] Release Apache Juneau 6.4.0-incubating RC2
Date Thu, 21 Sep 2017 22:01:23 GMT
Just to add:

 > Maybe it's JVM vendor-specific behavior?

Yes, I've now tested again after changing from an IBM JRE to an Oracle 
JRE - this resolves the problem.  It looks like this is specific to the 
IBM JRE then.  My Mac testing was done with an Oracle JRE, so I think 
this is probably JVM-specific rather than OS-specific.


On 21/09/2017 23:46, David Goddard wrote:
> Actual text is:
> 
> 2001年3月3日 (土曜日)
> (I've attached a copy as a text file also)
> 
> In this case, I it looks like the value between the parenthesis is the 
> day name, "Saturday".  So the expected value is just the date (2001年3月 
> 3日), but the day is being added in the process.
> 
> On 21/09/2017 22:45, James Bognar wrote:
>> Interesting.  So the behavior of...
>>
>> DateFormat.getDateInstance(DateFormat.FULL, locale).format(date);
>> DateFormat.getDateTimeInstance(DateFormat.FULL, DateFormat.FULL, locale
>> ).format(date);
>>
>> ...returns different formats depending on the OS.  Lovely.
>>
>> Maybe it's JVM vendor-specific behavior?
>>
>> I'm curious to know what's in those parentheses...
>> 2001?3?3? [*(???)* ]10?11?12? GMT
>>
>> Might give me something to google for.
>>
>> It's technically a test-only issue.  We can probably 'fix' the 
>> testcase by
>> just stripping out the formatting difference...
>>
>> @Test
>> public void test() {
>> BeanSession session = ps.getBeanContext().createSession(new
>> BeanSessionArgs(null, sessionLocale, sessionTimeZone, null));
>> String actual = session.convertToType(calendar, String.class);
>> *actual = actual.replaceAll("\\([^\\)]+\\) ", "");  // Fix 
>> Windows-specific
>> formatting difference*
>> assertEquals(expected, actual);
>> Object c2 = session.convertToType(actual, calendar.getClass());
>> String actual2 = session.convertToType(c2, String.class);
>> *actual2 = actual2.replaceAll("\\([^\\)]+\\) ", "");  // Fix
>> Windows-specific formatting difference*
>> assertEquals(expected, actual2);
>> }
>>
>>
>>
>>
>>
>> On Thu, Sep 21, 2017 at 3:11 PM, David Goddard <goddard@acm.org> wrote:
>>
>>> Hi,
>>>
>>> Yes, that fixed it, thanks.  It also still tests OK on my Mac after the
>>> change.
>>>
>>> I'm now running into some further test issues, also on Windows only.
>>>
>>> ########################
>>>
>>> Tests run: 460, Failures: 16, Errors: 0, Skipped: 0, Time elapsed: 0.247
>>> sec <<< FAILURE! - in org.apache.juneau.transforms.LocalizedDatesTest
>>> test[111](org.apache.juneau.transforms.LocalizedDatesTest)  Time 
>>> elapsed:
>>> 0.015 sec  <<< FAILURE!
>>> org.junit.ComparisonFailure: expected:<2001?3?3?[]> but was:<2001?3?3?[
>>> (???)]>
>>>          at org.apache.juneau.transforms.LocalizedDatesTest.test(Localiz
>>> edDatesTest.java:645)
>>>
>>> [...]
>>> test[423](org.apache.juneau.transforms.LocalizedDatesTest)  Time 
>>> elapsed:
>>> 0 sec  <<< FAILURE!
>>> org.junit.ComparisonFailure: expected:<2001?3?3? []10?11?12? GMT> but
>>> was:<2001?3?3? [(???) ]10?11?12? GMT>
>>>          at org.apache.juneau.transforms.LocalizedDatesTest.test(Localiz
>>> edDatesTest.java:645)
>>>
>>> test[424](org.apache.juneau.transforms.LocalizedDatesTest)  Time 
>>> elapsed:
>>> 0 sec  <<< FAILURE!
>>> org.junit.ComparisonFailure: expected:<2001?3?3? []10?11?12? GMT> but
>>> was:<2001?3?3? [(???) ]10?11?12? GMT>
>>>          at org.apache.juneau.transforms.LocalizedDatesTest.test(Localiz
>>> edDatesTest.java:645)
>>>
>>> ########################
>>>
>>>
>>> These are specific to date swap tests in Japanese & Korean:
>>>
>>> { "421", testDate.getTime(), DateSwap.DateTimeFull.class, "ja_JP", null,
>>> null, null, "2001年3月3日 10時11分12秒 GMT" },
>>> { "422", testDate.getTime(), DateSwap.DateTimeFull.class, Locale.JAPAN,
>>> null, null, null, "2001年3月3日 10時11分12秒 GMT"
},
>>> { "423", testDate.getTime(), DateSwap.DateTimeFull.class, null,
>>> Locale.JAPAN, null, null, "2001年3月3日 10時11分12秒
GMT" },
>>> { "424", testDate.getTime(), DateSwap.DateTimeFull.class, "en_UK",
>>> Locale.JAPAN, null, null, "2001年3月3日 10時11分12秒
GMT" },
>>> { "425", testDate.getTime(), DateSwap.DateTimeFull.class, "en_UK",
>>> Locale.KOREA, null, null, "2001ë…„ 3ì›” 3ì�¼ í† ìš”ì�¼
ì˜¤ì „ 10ì‹œ 
>>> 11분
>>> 12ì´ˆ GMT" },
>>> etc.
>>>
>>> All the date swaps where the test date contains Japanese or Korean
>>> characters in the date part fail in this way.  I initially thought it 
>>> was
>>> the code page of the file, but I've changed to UTF-8 from the default 
>>> and
>>> this didn't resolve this for me.  Again, this is specific to my Windows
>>> platform - all is fine on Mac.
>>>
>>> Given that this is a build test error, and specific to one platform (and
>>> possibly one machine), I'm not sure that it is a fatal problem for the
>>> release.
>>>
>>> David
>>>
>>>
>>>
>>> On 21/09/2017 14:55, James Bognar wrote:
>>>
>>>> Hi David,
>>>>
>>>> I don't have a Windows machine anymore :-(
>>>>
>>>> It looks like a test issue.  Is it only RDF tests that are failing?
>>>>
>>>> Can you find line 484 in org.apache.juneau.TestUtils in
>>>> juneau-core-tests...
>>>>
>>>> String[] e = expected.trim().split("\n"), a = 
>>>> actual.trim().split("\n");
>>>>
>>>> ...and change it to this?...
>>>>
>>>> String[] e = expected.trim().split("[\r\n]+"), a = actual.trim().split(
>>>> "[\r\n]+");
>>>>
>>>>
>>>> Background on this method:  Since Jena does not guarantee the order of
>>>> entries in the generated RDF (it's pretty much random), it's 
>>>> difficult to
>>>> do simple comparison validation.  So instead, we sort the expected and
>>>> actual lines and then check for comparison.  It's not perfect (XML
>>>> attribute order can also be random), but generally good enough for what
>>>> we're testing.
>>>>
>>>>
>>>>
>>>> On Thu, Sep 21, 2017 at 5:52 AM, David Goddard <goddard@acm.org> wrote:
>>>>
>>>> Thanks.
>>>>>
>>>>> I'm seeting a whole load of test failures in juneau-core parsing 
>>>>> (every
>>>>> round trip test is failing for me).  For example:
>>>>>
>>>>>
>>>>>> ByteArrayBase64SwapComboTest>ComboRoundTripTest.g32_parseRdf
>>>>> XmlR:701->ComboRoundTripTest.testParse:205 ByteArray2d/parseRdfXmlR
>>>>> parse-normal failed expected:<<rdf:RDF>[
>>>>>     <rdf:Seq>
>>>>>       <rdf:li>AQID</rdf:li>
>>>>>       <rdf:li>BAUG</rdf:li>
>>>>>       <rdf:li rdf:resource='http://www.w3.or
>>>>> g/1999/02/22-rdf-syntax-ns#nil'/
>>>>>
>>>>>>
>>>>>>     </rdf:Seq>
>>>>> </rdf:RDF>]
>>>>>
>>>>>> but was:<<rdf:RDF>[
>>>>>>
>>>>>     <rdf:Seq>
>>>>>       <rdf:li>AQID</rdf:li>
>>>>>       <rdf:li>BAUG</rdf:li>
>>>>>       <rdf:li rdf:resource='http://www.w3.or
>>>>> g/1999/02/22-rdf-syntax-ns#nil'/
>>>>>
>>>>>>
>>>>>>     </rdf:Seq>
>>>>> </rdf:RDF>
>>>>> ]
>>>>>
>>>>>>
>>>>>>
>>>>> The only consistent difference I see is that the final closing square
>>>>> bracket is appearing on a new line.  Perhaps this is a character 
>>>>> encoding
>>>>> issue (although I wouldn't rule out user error) - these tests fail 
>>>>> on a
>>>>> Windows platform, but work fine on a Mac.
>>>>>
>>>>> David
>>>>>
>>>>>
>>>>>
>>>>> On 20/09/2017 15:39, James Bognar wrote:
>>>>>
>>>>> Indeed they are.
>>>>>>
>>>>>> I've fixed them in Git.  Thanks David!
>>>>>>
>>>>>> On Wed, Sep 20, 2017 at 8:25 AM, David Goddard <goddard@acm.org>

>>>>>> wrote:
>>>>>>
>>>>>> I'm seeing a couple of issues with the Eclipse project names when
>>>>>>
>>>>>>> importing a fresh clone into a workspace.
>>>>>>>
>>>>>>> juneau-microservice/.project has <name>juneau-rest</name>
>>>>>>> juneau-doc/.project has <name>juneau-marshall</name>
>>>>>>>
>>>>>>> I'm assuming these are copy/paste errors arising from the
>>>>>>> restructuring.
>>>>>>>
>>>>>>> David
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 19/09/2017 18:26, Charles Mims wrote:
>>>>>>>
>>>>>>> +1, with intermittent test failures in Apache Juneau Microservice

>>>>>>> Tests
>>>>>>>
>>>>>>>>
>>>>>>>> MD5 (apache-juneau-6.4.0-incubating-src.zip) =
>>>>>>>> e6ef05085093a5235cb9665c65a778fb
>>>>>>>> For me it failed on the 1st and 2nd try, passed on the 3rd.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, Sep 19, 2017 at 11:11 AM, James Bognar <
>>>>>>>> jamesbognar@apache.org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> ** At this time, I have met “Broken Pipe” issue too.
I think we 
>>>>>>>> need
>>>>>>>> to
>>>>>>>>
>>>>>>>>> handle this problem soon.
>>>>>>>>>
>>>>>>>>> Darn.
>>>>>>>>>
>>>>>>>>> I'm thinking it must be an issue with Jetty since we
just upgraded
>>>>>>>>> it.
>>>>>>>>>     From the Jetty side, the connection is open waiting
for 
>>>>>>>>> data, but
>>>>>>>>> that's
>>>>>>>>> all I know.
>>>>>>>>>
>>>>>>>>> I'll have to figure out how to use Fiddler and do some
low-level
>>>>>>>>> debugging.  It's really hard to reproduce though :-(
>>>>>>>>>
>>>>>>>>> On Tue, Sep 19, 2017 at 11:32 AM, Raphi D Lee <yidonguk@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> +1
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> SHA1, MD5 Checksum OK
>>>>>>>>>> Maven Build OK
>>>>>>>>>>
>>>>>>>>>> ** At this time, I have met “Broken Pipe” issue
too. I think 
>>>>>>>>>> we need
>>>>>>>>>> to
>>>>>>>>>> handle this problem soon.
>>>>>>>>>>
>>>>>>>>>> [INFO] Reactor Summary:
>>>>>>>>>> [INFO]
>>>>>>>>>> [INFO] Apache Juneau (incubating) .........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 10.521 s]
>>>>>>>>>> [INFO] Apache Juneau - Core APIs ..........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.737 s]
>>>>>>>>>> [INFO] Apache Juneau Marshall .............................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 45.444 s]
>>>>>>>>>> [INFO] Apache Juneau Marshal RDF ..........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 3.558 s]
>>>>>>>>>> [INFO] Apache Juneau Data Transfer Objects ................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 6.813 s]
>>>>>>>>>> [INFO] Apache Juneau Core .................................
>>>>>>>>>> SUCCESS [
>>>>>>>>>> 1.025 s]
>>>>>>>>>> [INFO] Apache Juneau Config File API ......................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 1.928 s]
>>>>>>>>>> [INFO] Apache Juneau Core Tests ...........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [01:04
>>>>>>>>>> min]
>>>>>>>>>> [INFO] Apache Juneau - REST APIs ..........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.080 s]
>>>>>>>>>> [INFO] Apache Juneau REST Servlet API .....................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 2.331 s]
>>>>>>>>>> [INFO] Apache Juneau REST JAX/RS API ......................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.476 s]
>>>>>>>>>> [INFO] Apache Juneau REST Client API ......................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 1.005 s]
>>>>>>>>>> [INFO] Apache Juneau - Microservice APIs ..................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.068 s]
>>>>>>>>>> [INFO] Apache Juneau Microservice Server ..................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 1.588 s]
>>>>>>>>>> [INFO] Apache Juneau Microservice Template ................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 1.243 s]
>>>>>>>>>> [INFO] Apache Juneau - Examples ...........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.183 s]
>>>>>>>>>> [INFO] Apache Juneau REST Examples ........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 8.512 s]
>>>>>>>>>> [INFO] Apache Juneau Microservice Tests ...................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 24.522 s]
>>>>>>>>>> [INFO] Apache Juneau Core Examples ........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.287 s]
>>>>>>>>>> [INFO] Apache Juneau Javadocs .............................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.617 s]
>>>>>>>>>> [INFO] Apache Juneau - Release Engineering ................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.040 s]
>>>>>>>>>> [INFO] Apache Juneau UberJar ..............................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 1.008 s]
>>>>>>>>>> [INFO] Apache Juneau Distribution .........................

>>>>>>>>>> SUCCESS
>>>>>>>>>> [
>>>>>>>>>> 0.768 s]
>>>>>>>>>> [INFO] 
>>>>>>>>>> ------------------------------------------------------------
>>>>>>>>>> ------------
>>>>>>>>>> [INFO] BUILD SUCCESS
>>>>>>>>>> [INFO] 
>>>>>>>>>> ------------------------------------------------------------
>>>>>>>>>> ------------
>>>>>>>>>> [INFO] Total time: 03:01 min
>>>>>>>>>> [INFO] Finished at: 2017-09-19T20:11:43+09:00
>>>>>>>>>> [INFO] Final Memory: 87M/773M
>>>>>>>>>> [INFO] 
>>>>>>>>>> ------------------------------------------------------------
>>>>>>>>>> ------------
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Raphi D Lee, yidonguk@gmail.com
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 2017. 9. 18. 오전 9:54, James Bognar <jamesbognar@apache.org>

>>>>>>>>>> 작성:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> I am pleased to be calling this vote for the
source release of
>>>>>>>>>>> Apache
>>>>>>>>>>> Juneau 6.4.0-incubating RC2.
>>>>>>>>>>> This includes some fixes for bugs found in RC1
and some 
>>>>>>>>>>> packaging
>>>>>>>>>>> changes
>>>>>>>>>>> for the example and template projects.
>>>>>>>>>>>
>>>>>>>>>>> The list of new features can be found here:
>>>>>>>>>>> http://juneau.incubator.apache.org/site/apidocs/
>>>>>>>>>>>
>>>>>>>>>>> overview-summary.html#6.4.0
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> The binaries are available at:
>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/juneau/
>>>>>>>>>>>
>>>>>>>>>>> binaries/juneau-6.4.0-incubating-RC2/
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> The release candidate to be voted over is available
at:
>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/juneau/
>>>>>>>>>>>
>>>>>>>>>>> source/juneau-6.4.0-incubating-RC2/
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> SHA-1 checksums:
>>>>>>>>>>> aeb89ecf6b0da5e8b594455a349f1f7efa483f81 apache-juneau-6.4.
>>>>>>>>>>> 0-incubating-src.zip
>>>>>>>>>>> c3d4a1d7c21142a4006876419729d9f0c352203e apache-juneau-6.4.
>>>>>>>>>>> 0-incubating-bin.zip
>>>>>>>>>>>
>>>>>>>>>>> MD5 checksums:
>>>>>>>>>>> e6ef05085093a5235cb9665c65a778fb apache-juneau-6.4.0-incubating
>>>>>>>>>>> -src.zip
>>>>>>>>>>> 4e96d5047c0e9f03f0def2d017521f13 apache-juneau-6.4.0-incubating
>>>>>>>>>>> -bin.zip
>>>>>>>>>>>
>>>>>>>>>>> Build the release candidate using:
>>>>>>>>>>> mvn clean install
>>>>>>>>>>>
>>>>>>>>>>> The release candidate is signed with a GPG key
available at:
>>>>>>>>>>> https://dist.apache.org/repos/dist/release/incubator/juneau/KEYS
>>>>>>>>>>>
>>>>>>>>>>> A staged Maven repository is available for review
at:
>>>>>>>>>>> https://repository.apache.org/content/repositories/orgapache
>>>>>>>>>>> juneau-1016/
>>>>>>>>>>>
>>>>>>>>>>> The Git commit for this release is...
>>>>>>>>>>> *https://git-wip-us.apache.org/repos/asf?p=incubator-
>>>>>>>>>>>
>>>>>>>>>>> juneau.git;a=commit;h=6de998193807eeec40e6f297f6b70222552f3b37
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> <https://git-wip-us.apache.org/repos/asf?p=incubator-
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> juneau.git;a=commit;h=6de998193807eeec40e6f297f6b70222552f3b37>*
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Please vote on releasing this package as:
>>>>>>>>>>> Apache Juneau 6.4.0-incubating
>>>>>>>>>>>
>>>>>>>>>>> This vote will be open until 20-Sep-2017 9:00pm
EST and 
>>>>>>>>>>> passes if a
>>>>>>>>>>> majority of at least three +1 Apache Juneau PPMC
votes are cast.
>>>>>>>>>>>
>>>>>>>>>>> [ ] +1 Release this package
>>>>>>>>>>> [ ] 0 I don't feel strongly about it, but don't
object
>>>>>>>>>>> [ ] -1 Do not release this package because...
>>>>>>>>>>>
>>>>>>>>>>> Anyone can participate in testing and voting,
not just 
>>>>>>>>>>> committers,
>>>>>>>>>>> please
>>>>>>>>>>> feel free to try out the release candidate and
provide your 
>>>>>>>>>>> votes.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
> 


Mime
View raw message