juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Bognar <jamesbog...@gmail.com>
Subject Re: Sample Codes on Documents
Date Wed, 24 May 2017 01:26:22 GMT
Yes, I'm apparently unfamiliar with pull requests.  Can someone more
familiar with git document how to use them?


On Tue, May 23, 2017 at 8:01 PM John D. Ament <johndament@apache.org> wrote:

> Hi James,
>
> We should discuss further.  With github integration specifically, pull
> requests are pretty normal.  They have some benefits - we can track on list
> who created it and the commit history retains the original author name.
> This process has become the industry norm.
>
> I've raised an infra issue over the fact that we didn't receive a
> notification of this PR.  Though ideally we should have JIRAs covering
> changes whenever possible.
>
> John
>
> On Tue, May 23, 2017 at 2:04 PM James Bognar <james.bognar@salesforce.com>
> wrote:
>
> > Yep.  I think that's all he needs.  He can just send me patch files
> > attached to dev@juneau emails.
> >
> > On Tue, May 23, 2017 at 2:02 PM, Craig Russell <apache.clr@gmail.com>
> > wrote:
> >
> > > I think it is appropriate for these messages to be on dev@juneau.
> > >
> > > My point is: what else does Raphi need to do? Doesn't his pull request
> > > give you everything you need to commit his changes to the main repo?
> > Isn't
> > > that how pull requests work?
> > >
> > > Craig
> > >
> > > > On May 23, 2017, at 7:31 AM, James Bognar <
> james.bognar@salesforce.com
> > >
> > > wrote:
> > > >
> > > > Hi Craig...
> > > >
> > > > That message was meant for Raphi.  If he has changes he wants to make
> > to
> > > > the website, he can send me a patch file and I'll commit it for him.
> > > >
> > > > On Tue, May 23, 2017 at 10:27 AM, Craig Russell <
> apache.clr@gmail.com>
> > > > wrote:
> > > >
> > > >> Hi James,
> > > >>
> > > >> Maybe I don't understand your request, or don't understand git.
> > > >>
> > > >> The pull request has the patch included. If you click on the "typos
> > and
> > > >> errors" link or the 29fc3be link the diff opens up. And then you can
> > > view
> > > >> the whole file, comment, etc.
> > > >>
> > > >> I'm not set up to directly commit from the pull request page, but
> you
> > > >> should be able to.
> > > >>
> > > >> Is some other work flow better?
> > > >>
> > > >> Craig
> > > >>
> > > >>> On May 23, 2017, at 7:05 AM, James Bognar <
> > james.bognar@salesforce.com
> > > >
> > > >> wrote:
> > > >>>
> > > >>> Hi Raphi,
> > > >>>
> > > >>> If you have any changes, can you attach a git patch file and I'll
> > > >>> review/commit it for you?  I think that's the approach our team
is
> > > going
> > > >> to
> > > >>> start using for code submissions until developers get committer
> role.
> > > >>>
> > > >>> On Tue, May 23, 2017 at 6:48 AM, Raphi D Lee <yidonguk@gmail.com>
> > > wrote:
> > > >>>
> > > >>>> Thank you John, Craig.
> > > >>>>
> > > >>>> I’ve created new pull request on github.
> > > >>>>
> > > >>>> https://github.com/apache/incubator-juneau-website/pull/1
<
> > > >>>> https://github.com/apache/incubator-juneau-website/pull/1>
> > > >>>>
> > > >>>> Thank you again.
> > > >>>>
> > > >>>>
> > > >>>> Raphi D Lee, yidonguk@gmail.com
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>>> 2017. 5. 23. 오전 5:35, Craig Russell <apache.clr@gmail.com>
작성:
> > > >>>>>
> > > >>>>> Thanks for that, John.
> > > >>>>>
> > > >>>>> On the "source code" page
> > http://juneau.apache.org/#sourceCode.html
> > > it
> > > >>>> does have a link "GIT Repository for this website"
> > > >>>> https://git-wip-us.apache.org/repos/asf?p=incubator-juneau-
> > > website.git
> > > >>>> that I totally missed.
> > > >>>>>
> > > >>>>> Craig
> > > >>>>>
> > > >>>>>> On May 22, 2017, at 1:13 PM, John D. Ament <
> johndament@apache.org
> > >
> > > >>>> wrote:
> > > >>>>>>
> > > >>>>>> Hi Raphi,
> > > >>>>>>
> > > >>>>>> Actually the website is on github as well -
> > > >>>>>> https://github.com/apache/incubator-juneau-website
- please
> note
> > > that
> > > >>>> the
> > > >>>>>> branch is called "asf-site"
> > > >>>>>>
> > > >>>>>> John
> > > >>>>>>
> > > >>>>>> On Mon, May 22, 2017 at 4:10 PM Craig Russell <
> > apache.clr@gmail.com
> > > >
> > > >>>> wrote:
> > > >>>>>>
> > > >>>>>>> Hi Raphi,
> > > >>>>>>>
> > > >>>>>>>
> > > >>>>>>>> On May 22, 2017, at 2:48 AM, Raphi D Lee <yidonguk@gmail.com>
> > > >> wrote:
> > > >>>>>>>>
> > > >>>>>>>> Hi All,
> > > >>>>>>>>
> > > >>>>>>>> There’s no (mirror) repository on Github
for juneau website.
> > > >>>>>>>> Is there any way to create pull request without
it?
> > > >>>>>>>> Please give me a hint.
> > > >>>>>>>
> > > >>>>>>> Excellent question.
> > > >>>>>>>
> > > >>>>>>> I'd like the developers to respond what the best
way is to
> > receive
> > > >>>> patches
> > > >>>>>>> to the web site.
> > > >>>>>>>
> > > >>>>>>> Craig
> > > >>>>>>>
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>> Raphi D Lee, yidonguk@gmail.com
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>>
> > > >>>>>>>>> 2017. 5. 22. 오전 5:26, Craig Russell
<apache.clr@gmail.com>
> 작성:
> > > >>>>>>>>>
> > > >>>>>>>>> Hi Raphi,
> > > >>>>>>>>>
> > > >>>>>>>>> It's great that you have become involved
so quickly as a
> > > developer
> > > >> in
> > > >>>>>>> the project.
> > > >>>>>>>>>
> > > >>>>>>>>>
> http://www.apache.org/foundation/how-it-works.html#developers
> > <
> > > >>>>>>> http://www.apache.org/foundation/how-it-works.html#developers>
> > > >>>>>>>>>
> > > >>>>>>>>> To get started, can you create a pull
request for your
> changes?
> > > >> Then
> > > >>>> a
> > > >>>>>>> committer can update the repository.
> > > >>>>>>>>>
> > > >>>>>>>>>
> http://www.apache.org/foundation/how-it-works.html#committers
> > <
> > > >>>>>>> http://www.apache.org/foundation/how-it-works.html#committers>
> > > >>>>>>>>>
> > > >>>>>>>>> Keep up the work on the project and in
due time the project
> > will
> > > >> vote
> > > >>>>>>> on offering you commit privileges.
> > > >>>>>>>>>
> > > >>>>>>>>> Regards,
> > > >>>>>>>>>
> > > >>>>>>>>> Craig
> > > >>>>>>>>>
> > > >>>>>>>>>> On May 20, 2017, at 11:32 PM, Raphi
D Lee <
> yidonguk@gmail.com
> > > >>>> <mailto:
> > > >>>>>>> yidonguk@gmail.com>> wrote:
> > > >>>>>>>>>>
> > > >>>>>>>>>> Okay, I’ll check it over. :)
> > > >>>>>>>>>>
> > > >>>>>>>>>> Thanks
> > > >>>>>>>>>>
> > > >>>>>>>>>> Raphi D Lee, yidonguk@gmail.com
> > > >>>>>>>>>>
> > > >>>>>>>>>>
> > > >>>>>>>>>>
> > > >>>>>>>>>>
> > > >>>>>>>>>>> 2017. 5. 21. 오후 3:11, James
Bognar <
> > > james.bognar@salesforce.com>
> > > >>>> 작성:
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Hey Raphi,
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> I'm going to have to defer to
one of the mentors on how
> that
> > > >> works
> > > >>>>>>> for new
> > > >>>>>>>>>>> committers.  I believe you get
a username once you've
> signed
> > > and
> > > >>>>>>> emailed
> > > >>>>>>>>>>> your Apache Contributor License
Agreement.  Then it's just
> > your
> > > >>>> apache
> > > >>>>>>>>>>> account.
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> On Sun, May 21, 2017 at 2:04 AM,
Raphi D Lee <
> > > yidonguk@gmail.com
> > > >>>>>>> <mailto:yidonguk@gmail.com> <mailto:yidonguk@gmail.com
> <mailto:
> > > >>>>>>> yidonguk@gmail.com>>> wrote:
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>> Hey.. James
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Authentication is needed to
commit yo the master branch.
> > > >>>>>>>>>>>> Could you tell me how can
I have an username for it?
> > > >>>>>>>>>>>> I am sorry to bother you.
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Thanks
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> Raphi D Lee, yidonguk@gmail.com
<mailto:
> yidonguk@gmail.com>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>> 2017. 5. 21. 오후 2:52,
James Bognar <
> > > >> james.bognar@salesforce.com
> > > >>>>>>> <mailto:james.bognar@salesforce.com>>
작성:
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> Yep...commit it to the
master branch.
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> On Sun, May 21, 2017 at
1:50 AM, Raphi D Lee <
> > > >> yidonguk@gmail.com
> > > >>>>>>> <mailto:yidonguk@gmail.com>
> > > >>>>>>>>>>>> <mailto:yidonguk@gmail.com
<mailto:yidonguk@gmail.com>
> > > <mailto:
> > > >>>>>>> yidonguk@gmail.com <mailto:yidonguk@gmail.com>>>>
wrote:
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>> Thank you James,
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>> Could you tell me
What “deliver changes” means? Push to
> > git
> > > >>>> origin?
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>> Raphi D Lee, yidonguk@gmail.com
<mailto:
> > yidonguk@gmail.com>
> > > >>>>>>> <mailto:yidonguk@gmail.com <mailto:yidonguk@gmail.com>>
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> 2017. 5. 21. 오후
2:32, James Bognar <
> > > >>>> james.bognar@salesforce.com
> > > >>>>>>> <mailto:james.bognar@salesforce.com> <mailto:james.bognar@
> > > >>>> salesforce.com
> > > >>>>>>> <mailto:james.bognar@salesforce.com>>>
작성:
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> Hi Raphi,
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> These all look
great!  Thanks for catching them!
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> Line 812 on overview-summary.html
is okay though.
> There
> > > >>>> *should*
> > > >>>>>>> be a
> > > >>>>>>>>>>>>>> ws() method on SerializerGroupBuilder.
 I just added it.
> > > >> Thanks
> > > >>>>>>> for
> > > >>>>>>>>>>>>>> finding that as well.
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> You can deliver
these changes.
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> On Sun, May 21,
2017 at 12:47 AM, Raphi D Lee <
> > > >>>> yidonguk@gmail.com
> > > >>>>>>> <mailto:yidonguk@gmail.com> <mailto:yidonguk@gmail.com
> <mailto:
> > > >>>>>>> yidonguk@gmail.com>>
> > > >>>>>>>>>>>>>> <mailto:yidonguk@gmail.com
<mailto:yidonguk@gmail.com>
> > > >> <mailto:
> > > >>>>>>> yidonguk@gmail.com <mailto:yidonguk@gmail.com>>
<mailto:
> > > >>>> yidonguk@gmail.com
> > > >>>>>>> <mailto:yidonguk@gmail.com> <mailto:yidonguk@gmail.com
> <mailto:
> > > >>>>>>> yidonguk@gmail.com>>>>> wrote:
> > > >>>>>>>>>>>>>>> Hi all,
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> I’ve found some
typos and errors in sample codes in
> > > overview
> > > >>>>>>> document
> > > >>>>>>>>>>>>>> and javadocs while
reviewing.
> > > >>>>>>>>>>>>>>> Please let me
know if there’s bad modifications.
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> Thanks,
> > > >>>>>>>>>>>>>>> Regards
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> Raphi D Lee, yidonguk@gmail.com
<mailto:
> > yidonguk@gmail.com
> > > >
> > > >>>>>>> <mailto:yidonguk@gmail.com <mailto:yidonguk@gmail.com>>
> <mailto:
> > > >>>>>>> yidonguk@gmail.com <mailto:yidonguk@gmail.com>
<mailto:
> > > >>>> yidonguk@gmail.com
> > > >>>>>>> <mailto:yidonguk@gmail.com>>> <mailto:
> > > >>>>>>>>>>>> yidonguk@gmail.com <mailto:yidonguk@gmail.com>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>> --
> > > >>>>>>>>>>>>>>> James Bognar
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>>
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> --
> > > >>>>>>>>>>>>> James Bognar
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> --
> > > >>>>>>>>>>> James Bognar
> > > >>>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>> Craig L Russell
> > > >>>>>>>>> clr@apache.org <mailto:clr@apache.org>
> > > >>>>>>>
> > > >>>>>>> Craig L Russell
> > > >>>>>>> Secretary, Apache Software Foundation
> > > >>>>>>> clr@apache.org http://db.apache.org/jdo
> > > >>>>>>>
> > > >>>>>>>
> > > >>>>>
> > > >>>>> Craig L Russell
> > > >>>>> Secretary, Apache Software Foundation
> > > >>>>> clr@apache.org http://db.apache.org/jdo
> > > >>>>>
> > > >>>>
> > > >>>>
> > > >>>
> > > >>>
> > > >>> --
> > > >>> James Bognar
> > > >>
> > > >> Craig L Russell
> > > >> Secretary, Apache Software Foundation
> > > >> clr@apache.org http://db.apache.org/jdo
> > > >>
> > > >>
> > > >
> > > >
> > > > --
> > > > James Bognar
> > >
> > > Craig L Russell
> > > Secretary, Apache Software Foundation
> > > clr@apache.org http://db.apache.org/jdo
> > >
> > >
> >
> >
> > --
> > James Bognar
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message