juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Bognar <james.bog...@salesforce.com>
Subject Re: Sample Codes on Documents
Date Sun, 21 May 2017 05:52:43 GMT
Yep...commit it to the master branch.

On Sun, May 21, 2017 at 1:50 AM, Raphi D Lee <yidonguk@gmail.com> wrote:

> Thank you James,
>
> Could you tell me What “deliver changes” means? Push to git origin?
>
>
> Raphi D Lee, yidonguk@gmail.com
>
>
>
>
> > 2017. 5. 21. 오후 2:32, James Bognar <james.bognar@salesforce.com> 작성:
> >
> > Hi Raphi,
> >
> > These all look great!  Thanks for catching them!
> >
> > Line 812 on overview-summary.html is okay though.  There *should* be a
> ws() method on SerializerGroupBuilder.  I just added it.  Thanks for
> finding that as well.
> >
> > You can deliver these changes.
> >
> > On Sun, May 21, 2017 at 12:47 AM, Raphi D Lee <yidonguk@gmail.com
> <mailto:yidonguk@gmail.com>> wrote:
> > Hi all,
> >
> > I’ve found some typos and errors in sample codes in overview document
> and javadocs while reviewing.
> > Please let me know if there’s bad modifications.
> >
> > Thanks,
> > Regards
> >
> >
> >
> >
> >
> >
> >
> >
> > Raphi D Lee, yidonguk@gmail.com <mailto:yidonguk@gmail.com>
> >
> >
> >
> >
> >
> >
> >
> > --
> > James Bognar
>
>


-- 
James Bognar

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message