juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Bognar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (JUNEAU-24) Fix release issues discovered by Stian
Date Mon, 12 Dec 2016 14:40:59 GMT

     [ https://issues.apache.org/jira/browse/JUNEAU-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Bognar updated JUNEAU-24:
-------------------------------
    Description: 
1) ./binaries/juneau-6.0.1-incubating-RC2/juneau-6.0.1-incubating-bin.zip does not unpack
into a single directory, but pollutes my download folder with multiple generic files and folders
like "osgi-bundles/".
I would recommend to change this to have everything under a single top-level folder apache-juneau-6.0.1/
  (or apache-juneau-6.0.1-bin/if you like)

2) The distro filenames does not include "apache-" prefix in the filename or unpacked foldername.
This is not required, but recommended, e.g. I would have after releasing:
./juneau/source/juneau-6.0.1-incubating/apache-juneau-6.0.1-incubating-src.zip
unpacking to apache-juneau-6.0.1-incubating instead of juneau-6.0.1-incubating.
If you want I can have a look at the Maven assembler config on how to set such a <finalName>
for the dists -- BTW, you have to be careful not to set the <finalName> for the master
pom.xml  as it would affect every module (that would wrongly make juneau-microservice/target/apache-juneau-6.0.1.jar)

3) The vote email didn't include checksums of the release artifact under juneau/binaries/juneau-6.0.1-incubating-RC2
-- although Apache says that "source is king" and binaries are just for convenience, those
binaries are still subject to the Release vote. So it's best practice to include either all
the hashes, or the SVN revision number (svn log https://dist.apache.org/repos/dist/dev/incubator/juneau
| head says r17190).

4) Localization test bug....already fixed in Git.

5) Remove .classpath, .project, and .settings from Eclipse.
This is not generally done in Maven projects at ASF I've come across, mainly because there
will be frequent cross-developer cross-machine "conflicts" in such files. With the m2eclipse
plugin now built into Eclipse it is also now just as easy to use "Import from Existing Maven
project" than to use "Import existing project" (which would recreate those files based on
pom.xml).
However this would make it harder to share the codestyle templates etc. without moving to
checkstyle or similar.
There are of course also other IDEs - ASF projects would generally be neutral about what editor
people should use.
Do I understand that the project has decided to include the Eclipse files in git? I couldn't
find it in the list archive.
The .settings include a template which hard-codes the @author to James Bognar:

6) Remove @author tags.

> Fix release issues discovered by Stian
> --------------------------------------
>
>                 Key: JUNEAU-24
>                 URL: https://issues.apache.org/jira/browse/JUNEAU-24
>             Project: Juneau
>          Issue Type: Bug
>          Components: Code
>    Affects Versions: 6.0.1
>            Reporter: James Bognar
>            Assignee: James Bognar
>
> 1) ./binaries/juneau-6.0.1-incubating-RC2/juneau-6.0.1-incubating-bin.zip does not unpack
into a single directory, but pollutes my download folder with multiple generic files and folders
like "osgi-bundles/".
> I would recommend to change this to have everything under a single top-level folder apache-juneau-6.0.1/
  (or apache-juneau-6.0.1-bin/if you like)
> 2) The distro filenames does not include "apache-" prefix in the filename or unpacked
foldername. This is not required, but recommended, e.g. I would have after releasing:
> ./juneau/source/juneau-6.0.1-incubating/apache-juneau-6.0.1-incubating-src.zip
> unpacking to apache-juneau-6.0.1-incubating instead of juneau-6.0.1-incubating.
> If you want I can have a look at the Maven assembler config on how to set such a <finalName>
for the dists -- BTW, you have to be careful not to set the <finalName> for the master
pom.xml  as it would affect every module (that would wrongly make juneau-microservice/target/apache-juneau-6.0.1.jar)
> 3) The vote email didn't include checksums of the release artifact under juneau/binaries/juneau-6.0.1-incubating-RC2
-- although Apache says that "source is king" and binaries are just for convenience, those
binaries are still subject to the Release vote. So it's best practice to include either all
the hashes, or the SVN revision number (svn log https://dist.apache.org/repos/dist/dev/incubator/juneau
| head says r17190).
> 4) Localization test bug....already fixed in Git.
> 5) Remove .classpath, .project, and .settings from Eclipse.
> This is not generally done in Maven projects at ASF I've come across, mainly because
there will be frequent cross-developer cross-machine "conflicts" in such files. With the m2eclipse
plugin now built into Eclipse it is also now just as easy to use "Import from Existing Maven
project" than to use "Import existing project" (which would recreate those files based on
pom.xml).
> However this would make it harder to share the codestyle templates etc. without moving
to checkstyle or similar.
> There are of course also other IDEs - ASF projects would generally be neutral about what
editor people should use.
> Do I understand that the project has decided to include the Eclipse files in git? I couldn't
find it in the list archive.
> The .settings include a template which hard-codes the @author to James Bognar:
> 6) Remove @author tags.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message