juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: [VOTE] Release Apache Juneau 6.0.1-incubating RC2
Date Sat, 10 Dec 2016 10:55:03 GMT
If you are OK with including the bug in 6.0.1 (as you already fixed in
git), then I'll have another go at reviewing RC2 this weekend (I stopped
after finding that bug) using LANG=C.



On 8 Dec 2016 3:39 pm, "James Bognar" <james.bognar@salesforce.com> wrote:

> Sorry, I've been unavailable this week due to recovery from surgery.
>
> I haven't gotten any +1s from anyone yet.  Can I get a quick role call so I
> can create a new release?
>
> The remaining localization testcase failure reported by Stian has been
> fixed in Git, but is not part of this release candidate.
>
> On Thu, Dec 1, 2016 at 9:13 AM, James Bognar <james.bognar@salesforce.com>
> wrote:
>
> > Hi Stian,
> >
> > I'll check these out. These are testcase-only issues.
> >
> > Backstory....
> >
> > Juneau doesn't 'natively' handle Date and Calendar objects. Instead,
> > you're supposed to use a swap (which swaps out the Date object for a
> String
> > object before serialization, and vis-versa before parsing). This allows
> you
> > to pick how dates are rendered.
> >
> > The CalendarSwap and DateSwap classes have predefined ISO8601 and RFC2822
> > swaps which are what is typically used in real-world scenarios. But it
> also
> > has a Simple swap that's just a SimpleDateFormat.MEDIUM pattern that
> > doesn't localize well.
> >
> > These testcases are stumbling on testing that Simple swap. So yea, the
> > dates look weird because I'm testing a non-typical scenario.
> >
> > On Thu, Dec 1, 2016 at 4:52 AM Stian Soiland-Reyes <stain@apache.org>
> > wrote:
> >
> >> To replicate it should be enough for you to do
> >>
> >> export LANG=en_GB.UTF-8
> >>
> >> stain@biggiebuntu:/tmp/91/dist/source/juneau-6.0.1-
> >> incubating-RC2/juneau-6.0.1-incubating/juneau-server-test$
> >> locale
> >> LANG=en_GB.UTF-8
> >> LANGUAGE=en_GB:en
> >> LC_CTYPE="en_GB.UTF-8"
> >> LC_NUMERIC="en_GB.UTF-8"
> >> LC_TIME="en_GB.UTF-8"
> >> LC_COLLATE="en_GB.UTF-8"
> >> LC_MONETARY="en_GB.UTF-8"
> >> LC_MESSAGES="en_GB.UTF-8"
> >> LC_PAPER="en_GB.UTF-8"
> >> LC_NAME="en_GB.UTF-8"
> >> LC_ADDRESS="en_GB.UTF-8"
> >> LC_TELEPHONE="en_GB.UTF-8"
> >> LC_MEASUREMENT="en_GB.UTF-8"
> >> LC_IDENTIFICATION="en_GB.UTF-8"
> >> LC_ALL=
> >>
> >> If I do
> >>   export LANG=C
> >> these tests pass.
> >>
> >> But this seems to indicate that the Juneau server is also sensitive to
> >> which locale it is started from.
> >>
> >>
> >> On 1 December 2016 at 12:49, Stian Soiland-Reyes <stain@apache.org>
> >> wrote:
> >> > I get a similar locale date test error as before, but now in
> >> > org.apache.juneau.server.samples._TestSuite:
> >> >
> >> > [2016.12.01 12:11:53 WARNING] Server stopped.
> >> > Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.76
> >> > sec <<< FAILURE! - in org.apache.juneau.server.samples._TestSuite
> >> > testBasic(org.apache.juneau.server.samples.
> >> SampleRemoteableServicesResourceTest)
> >> >  Time elapsed: 0.017 sec  <<< FAILURE!
> >> > org.junit.ComparisonFailure: expected:<... Person',birthDate:'[Aug 1,
> >> > ]1999',addresses:[{id...> but was:<...
> >> > Person',birthDate:'[01-Aug-]1999',addresses:[{id...>
> >> > at org.apache.juneau.server.samples.SampleRemoteableServicesResour
> >> ceTest.testBasic(SampleRemoteableServicesResourceTest.java:63)
> >> >
> >> > juneau-server-test as well fails with date errors:
> >> >
> >> > [2016.12.01 12:47:15 WARNING] [8efd5237.400.1] HTTP POST 400
> >> > /testParams/person/(name=John+Smith,birthDate=Jan+12~,+1952)
> >> >
> >> > org.apache.juneau.server.RestException: Invalid data conversion.
> >> > Could not convert PATH 'person' to type 'class
> >> > org.apache.juneau.samples.addressbook.Person' on method
> >> > 'org.apache.juneau.server.test.ParamsResource.doPost'.
> >> > at org.apache.juneau.server.RestServlet$MethodMeta.invoke(
> >> RestServlet.java:2700)
> >> > at org.apache.juneau.server.RestServlet$MultiMethod.
> >> invoke(RestServlet.java:2829)
> >> > at org.apache.juneau.server.RestServlet.service(
> RestServlet.java:1009)
> >> > at org.apache.juneau.server.RestServlet.service(RestServlet.java:981)
> >> > at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
> >> > at org.eclipse.jetty.servlet.ServletHolder.handle(
> >> ServletHolder.java:594)
> >> > at org.eclipse.jetty.servlet.ServletHandler.doHandle(
> >> ServletHandler.java:485)
> >> > ...
> >> > Caused by: org.apache.juneau.parser.ParseException: Parse exception
> >> > occurred at {currentProperty:{classMeta:{
> innerClass:'java.lang.String',
> >> classCategory:'STR'},beanDictionary:'org.apache.
> >> juneau.BeanDictionary@41e66c4b',uri:false,name:'birthDate',
> field:'public
> >> > java.util.Calendar
> >> > org.apache.juneau.samples.addressbook.Person.birthDate'}
> >> ,line:1,column:40}.
> >> > Unparseable date: "Jan 12, 1952"
> >> > ..
> >> > Caused by: org.apache.juneau.BeanRuntimeException: Unparseable date:
> >> > "Jan 12, 1952"
> >> > at org.apache.juneau.BeanPropertyMeta.set(BeanPropertyMeta.java:584)
> >> > ..
> >> > Caused by: org.apache.juneau.parser.ParseException: Unparseable date:
> >> > "Jan 12, 1952"
> >> > at org.apache.juneau.transforms.CalendarSwap.unswap(
> >> CalendarSwap.java:266)
> >> > ..
> >> > Caused by: java.text.ParseException: Unparseable date: "Jan 12, 1952"
> >> > at java.text.DateFormat.parse(DateFormat.java:366)
> >> > at org.apache.juneau.transforms.CalendarSwap.unswap(
> >> CalendarSwap.java:264)
> >> >
> >> > (a locale specific URL parameter "birthDate=Jan+12~,+1952" does not
> >> > sound like particularly good REST design - why is this not using
> >> > ISO8601 format like birthDate=1952-01-12 ? )
> >> >
> >> > On 29 November 2016 at 14:26, James Bognar <jamesbognar@apache.org>
> >> wrote:
> >> >> I am pleased to be calling this vote for the source release of Apache
> >> >> Juneau 6.0.1-incubating RC2.
> >> >>
> >> >> To discuss this release candidate, use the corresponding [DISCUSS]
> >> thread.
> >> >>
> >> >> The binaries are available at:
> >> >> https://dist.apache.org/repos/dist/dev/incubator/juneau/
> >> binaries/juneau-6.0.1-incubating-RC2/
> >> >>
> >> >> The release candidate to be voted over is available at:
> >> >> https://dist.apache.org/repos/dist/dev/incubator/juneau/
> >> source/juneau-6.0.1-incubating-RC2/
> >> >>
> >> >> SHA-1 checksums:
> >> >> 21fe18adf4f5089e0b3a48a160707c4c2e080e0e
> juneau-6.0.1-incubating-src.
> >> zip
> >> >>
> >> >> MD5 checksums:
> >> >> b6ab34faf3f6c80139406432605347ef juneau-6.0.1-incubating-src.zip
> >> >>
> >> >> Build the release candidate using:
> >> >>
> >> >> mvn clean install
> >> >>
> >> >> The release candidate is signed with a GPG key available at:
> >> >> https://dist.apache.org/repos/dist/release/incubator/juneau/KEYS
> >> >>
> >> >> A staged Maven repository is available for review at:
> >> >> https://repository.apache.org/content/repositories/
> >> orgapachejuneau-1006/
> >> >>
> >> >> Please vote on releasing this package as:
> >> >> Apache Juneau 6.0.1-incubating
> >> >>
> >> >> The vote is open for at least 72 hours and passes if a majority of
at
> >> least
> >> >> three +1 Apache Juneau PPMC votes are cast.
> >> >> [ ] +1 Release this package
> >> >> [ ] 0 I don't feel strongly about it, but don't object
> >> >> [ ] -1 Do not release this package because...
> >> >>
> >> >> Anyone can participate in testing and voting, not just committers,
> >> please
> >> >> feel free to try out the release candidate and provide your votes.
> >> >
> >> >
> >> >
> >> > --
> >> > Stian Soiland-Reyes
> >> > http://orcid.org/0000-0001-9842-9718
> >>
> >>
> >>
> >> --
> >> Stian Soiland-Reyes
> >> http://orcid.org/0000-0001-9842-9718
> >>
> >
>
>
> --
> James Bognar
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message