juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: [VOTE] Release Apache Juneau 6.0.1-incubating RC3
Date Tue, 27 Dec 2016 22:36:16 GMT
Sorry for coming late to the party..!

My vote: +1 (binding)

+1 PGP signatures
+1 SHA1
+1 no binaries (beyond png/jpeg - should they not be under src/main/resources?)
+1 mvn apache-rat:check
+1 mvn clean install
+1 NOTICE, LICENSE (still in time for 2016 copyright :))
+0 DISCLAIMER present, but no trailing newline? (looks weird in terminal)
+1 mvn repo matches dist (same sha1 on -source-release.zip and juneau-all..jar)
+1 apache- in filename
+1 -incubating in filename/version
? git tag vs commit
+1 git vs source


Your vote email didn't mention git commit/tag (not legally required,
but best prectice), so I checked against
https://git-wip-us.apache.org/repos/asf?p=incubator-juneau.git;a=tag;h=refs/tags/juneau-6.0.1-incubating-RC3
aka
https://git-wip-us.apache.org/repos/asf?p=incubator-juneau.git;a=commit;h=dd034037676f28ee89e9ef4b1cabd2bce6e40d34

that commit matches the source release (except .project and .gitignore)


BTW, your git repository is quite large.. any reason why? It is just
17 MB checked out, but 147 MB in .git/. Perhaps there are some
unnecessary binaries in the history we can prune out?


DISCLAIMER seems to have stripped newlines, compare for instance with
https://github.com/apache/incubator-taverna-maven-parent/blob/master/DISCLAIMER

The ASF license header in the Java files also have an unusual
line-wrapping (much longer lines than usual) - not a problem, just an
observation. We have wider monitors now  - I guess 124 chars is OK for
most?


You have src.xml and bin.xml in root of the archive/repository which
can be a bit confusing, similar files are also in
juneau-distrib/src/assembly .. any reason we need both?



Tested with

stain@biggiebuntu:/tmp/jun$ mvn -v
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /home/stain/software/maven
Java version: 1.8.0_111, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-53-generic", arch: "amd64", family: "unix"




On 19 December 2016 at 21:37, James Bognar <jamesbognar@apache.org> wrote:
> I am pleased to be calling this vote for the source release of Apache
> Juneau 6.0.1-incubating RC3.
>
> To discuss this release candidate, use the corresponding [DISCUSS] thread.
>
> The binaries are available at:
> https://dist.apache.org/repos/dist/dev/incubator/juneau/binaries/juneau-6.0.1-incubating-RC3/
>
> The release candidate to be voted over is available at:
> https://dist.apache.org/repos/dist/dev/incubator/juneau/source/juneau-6.0.1-incubating-RC3/
>
> SHA-1 checksums:
> 4fc0fe29ad0f46ea6f7be276e087cff3c29413f0
> apache-juneau-6.0.1-incubating-src.zip
> f7181e416c6f4c03aa2bf2b9ef441c196599a3ea
> apache-juneau-6.0.1-incubating-bin.zip
>
> MD5 checksums:
> df85753f46fbe3ab9331cb459423db0d apache-juneau-6.0.1-incubating-src.zip
> b61c6dfbd0c0c39925babf32d4950b0a apache-juneau-6.0.1-incubating-bin.zip
>
> Build the release candidate using:
>
> mvn clean install
>
> The release candidate is signed with a GPG key available at:
> https://dist.apache.org/repos/dist/release/incubator/juneau/KEYS
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachejuneau-1008/
>
> Please vote on releasing this package as:
> Apache Juneau 6.0.1-incubating
>
> The vote is open for at least 72 hours and passes if a majority of at least
> three +1 Apache Juneau PPMC votes are cast.
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...



-- 
Stian Soiland-Reyes
http://orcid.org/0000-0001-9842-9718

Mime
View raw message