juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Bognar <james.bog...@salesforce.com>
Subject [CANCEL][VOTE] Release Apache Juneau 6.0.1-incubating RC2
Date Mon, 12 Dec 2016 02:28:46 GMT
While Stian technically gave a +1, I'm going to cancel this vote and fix
the issues he found.  Resolving these kinds of issues was the main reason
for 6.0.1, so I don't see any reason not to fix them first.

Thank you all for your input and I'll spin an RC3 soon.

On Sun, Dec 11, 2016 at 8:40 PM Stian Soiland-Reyes <stain@apache.org>
wrote:

> Your VOTE email didn't include a git tag or a commit ID. It's highly
>
> recommended. Easiest is just by selecting the tag from
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-juneau.git and
>
> include the tag's URL in the email, as the URL itself also includes
>
> the commit ID (or tag ID if it's a signed tag).
>
>
>
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-juneau.git;a=commit;h=cdc648b99d4e66309edf693c2b6160938c26f4e4
>
>
>
> (I'll assume the above tag)
>
>
>
> My vote:
>
>
>
> +1 (IPMC binding)
>
>
>
>
>
> Checked:
>
>
>
> +1 sha1/md5
>
> +1 asc
>
> -0 source release does not have "apache-" in archive/folder name
>
> +1 -incubator in archive names/version
>
> +0 git tag matches source release (except .classpath, .project. settings)
>
> +1 mvn apache-rat:check
>
> -1 mvn clean install fails (LANG=en_GB.UTF-8)
>
>    +1 LANG=C mvn clean install works though
>
> +1 DISCLAIMER
>
> +1 LICENSE, NOTICE
>
> +1 RELEASE-NOTES.txt
>
> +1 repository matches dist (same sha1 for source-release.zip and -bin.zip)
>
> +1 binaries archive has LICENSE, NOTICE, DISCLAIMER
>
>
>
>
>
> Tip: You should drop the old staging repository
>
> https://repository.apache.org/content/repositories/orgapachejuneau-1005/
>
> before uploading to create a new staging repo  - so you don't
>
> accidentally release the wrong one later on or copy/paste the wrong
>
> URL. (Also devs might in theory use the virtual group
>
> https://repository.apache.org/content/groups/staging/ to test the
>
> staged artifacts - which could then include the wrong JARs)
>
>
>
> The JARs in the Maven repository sometimes contain a file called
>
> empty.txt in the root package -- I don't think there would be much
>
> harm with it being on the classpath, but it would be tidier to avoid
>
> this.   If you want to have an empty folder to persist in Git I find
>
> it easier to add an empty .gitignore as that tends to be ignored by
>
> everything else -- also no longer misleading if the folder is no
>
> longer empty! :)
>
>
>
> The VOTE didn't include md5 of the -bin.zip, but it matches the one in
>
> the Staging repo (fe6d0f3f97a224eee00d6077843809ca4e33ee85)
>
>
>
>
>
> Good work!
>
>
>
>
>
> For the incubator VOTE, remember to include the git commit, binary
>
> sha1 and a warning about the locale setting for the test.
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message