jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject [jmeter] 10/13: JUnit doesn't need to have public test methods and sonar doesn't like them
Date Sat, 10 Oct 2020 11:29:11 GMT
This is an automated email from the ASF dual-hosted git repository.

fschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git

commit decb7a100dd0d30415c373fb76ff6a1341cb5235
Author: Felix Schumacher <felix.schumacher@internetallee.de>
AuthorDate: Fri Oct 9 18:26:24 2020 +0200

    JUnit doesn't need to have public test methods and sonar doesn't like them
---
 .../protocol/http/util/TestGraphQLRequestParamUtils.java   | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/util/TestGraphQLRequestParamUtils.java
b/src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/util/TestGraphQLRequestParamUtils.java
index 8316e68..545d6be 100644
--- a/src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/util/TestGraphQLRequestParamUtils.java
+++ b/src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/util/TestGraphQLRequestParamUtils.java
@@ -69,12 +69,12 @@ public class TestGraphQLRequestParamUtils {
     private GraphQLRequestParams params;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         params = new GraphQLRequestParams(OPERATION_NAME, QUERY, VARIABLES);
     }
 
     @Test
-    public void testIsGraphQLContentType() throws Exception {
+    void testIsGraphQLContentType() throws Exception {
         assertTrue(GraphQLRequestParamUtils.isGraphQLContentType("application/json"));
         assertTrue(GraphQLRequestParamUtils.isGraphQLContentType("application/json;charset=utf-8"));
         assertTrue(GraphQLRequestParamUtils.isGraphQLContentType("application/json; charset=utf-8"));
@@ -86,23 +86,23 @@ public class TestGraphQLRequestParamUtils {
     }
 
     @Test
-    public void testToPostBodyString() throws Exception {
+    void testToPostBodyString() throws Exception {
         assertEquals(EXPECTED_POST_BODY, GraphQLRequestParamUtils.toPostBodyString(params));
     }
 
     @Test
-    public void testQueryToGetParamValue() throws Exception {
+    void testQueryToGetParamValue() throws Exception {
         assertEquals(EXPECTED_QUERY_GET_PARAM_VALUE, GraphQLRequestParamUtils.queryToGetParamValue(params.getQuery()));
     }
 
     @Test
-    public void testVariablesToGetParamValue() throws Exception {
+    void testVariablesToGetParamValue() throws Exception {
         assertEquals(EXPECTED_VARIABLES_GET_PARAM_VALUE,
                 GraphQLRequestParamUtils.variablesToGetParamValue(params.getVariables()));
     }
 
     @Test
-    public void testToGraphQLRequestParamsWithPostData() throws Exception {
+    void testToGraphQLRequestParamsWithPostData() throws Exception {
         GraphQLRequestParams params = GraphQLRequestParamUtils
                 .toGraphQLRequestParams(EXPECTED_POST_BODY.getBytes(StandardCharsets.UTF_8),
null);
         assertNull(params.getOperationName());
@@ -154,7 +154,7 @@ public class TestGraphQLRequestParamUtils {
     }
 
     @Test
-    public void testToGraphQLRequestParamsWithHttpArguments() throws Exception {
+    void testToGraphQLRequestParamsWithHttpArguments() throws Exception {
         Arguments args = new Arguments();
         args.addArgument(new HTTPArgument("query", "query { droid { id }}", "=", false));
         GraphQLRequestParams params = GraphQLRequestParamUtils.toGraphQLRequestParams(args,
null);


Mime
View raw message