jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject [jmeter] branch master updated: Use Java naming conventions for method variables
Date Thu, 29 Oct 2020 17:59:11 GMT
This is an automated email from the ASF dual-hosted git repository.

fschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new 89dc220  Use Java naming conventions for method variables
89dc220 is described below

commit 89dc22052ac9b20062a1531a8688a5b2aa5d29b8
Author: Felix Schumacher <felix.schumacher@internetallee.de>
AuthorDate: Thu Oct 29 18:58:52 2020 +0100

    Use Java naming conventions for method variables
---
 .../jmeter/util/SecurityProviderLoaderTest.java    | 32 +++++++++++-----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/core/src/test/java/org/apache/jmeter/util/SecurityProviderLoaderTest.java
b/src/core/src/test/java/org/apache/jmeter/util/SecurityProviderLoaderTest.java
index 2571c0f..694b527 100644
--- a/src/core/src/test/java/org/apache/jmeter/util/SecurityProviderLoaderTest.java
+++ b/src/core/src/test/java/org/apache/jmeter/util/SecurityProviderLoaderTest.java
@@ -47,13 +47,13 @@ public class SecurityProviderLoaderTest {
 
         SecurityProviderLoader.addSecurityProvider(DummyProvider.class.getName());
 
-        Provider[] providers_after = Security.getProviders();
+        Provider[] providersAfter = Security.getProviders();
         Provider provider = Security.getProvider(DummyProvider.PROVIDER_NAME);
         try {
-            Assert.assertEquals(providersCountBefore + 1, providers_after.length);
+            Assert.assertEquals(providersCountBefore + 1, providersAfter.length);
             Assert.assertNotNull("Provider not installed.", provider);
             Assert.assertEquals(DummyProvider.class, provider.getClass());
-            Assert.assertEquals(provider, providers_after[providers_after.length - 1]);
+            Assert.assertEquals(provider, providersAfter[providersAfter.length - 1]);
         } catch (AssertionError e){
             Arrays.stream(providers).forEach(pro -> System.err.println(pro.getName()));
             throw e;
@@ -67,13 +67,13 @@ public class SecurityProviderLoaderTest {
 
         SecurityProviderLoader.addSecurityProvider(DummyProvider.class.getName()+":0:Configure");
 
-        Provider[] providers_after = Security.getProviders();
+        Provider[] providersAfter = Security.getProviders();
         Provider provider = Security.getProvider(DummyProvider.PROVIDER_NAME);
 
-        Assert.assertEquals(providersCountBefore + 1, providers_after.length);
+        Assert.assertEquals(providersCountBefore + 1, providersAfter.length);
         Assert.assertNotNull("Provider not installed.", provider);
         Assert.assertEquals(DummyProvider.class, provider.getClass());
-        Assert.assertEquals(provider, providers_after[providers_after.length - 1]);
+        Assert.assertEquals(provider, providersAfter[providersAfter.length - 1]);
     }
 
     @ParameterizedTest
@@ -97,13 +97,13 @@ public class SecurityProviderLoaderTest {
 
         SecurityProviderLoader.addSecurityProvider(DummyProvider.class.getName() + ":" +
position);
 
-        Provider[] providers_after = Security.getProviders();
+        Provider[] providersAfter = Security.getProviders();
         Provider provider = Security.getProvider(DummyProvider.PROVIDER_NAME);
 
-        Assert.assertEquals(providersCountBefore + 1, providers_after.length);
+        Assert.assertEquals(providersCountBefore + 1, providersAfter.length);
         Assert.assertNotNull(provider);
         Assert.assertEquals(DummyProvider.class, provider.getClass());
-        Assert.assertEquals(provider, providers_after[position == 0 ? providers_after.length
- 1 : position - 1]);
+        Assert.assertEquals(provider, providersAfter[position == 0 ? providersAfter.length
- 1 : position - 1]);
     }
 
     @ParameterizedTest
@@ -114,13 +114,13 @@ public class SecurityProviderLoaderTest {
 
         SecurityProviderLoader.addSecurityProvider(DummyProviderWithConfig.class.getName()
+ config);
 
-        Provider[] providers_after = Security.getProviders();
+        Provider[] providersAfter = Security.getProviders();
         Provider provider = Security.getProvider(DummyProviderWithConfig.PROVIDER_NAME);
 
         Assert.assertNotNull("Provider not installed.", provider);
-        Assert.assertEquals(providersCountBefore + 1, providers_after.length);
+        Assert.assertEquals(providersCountBefore + 1, providersAfter.length);
         Assert.assertEquals(DummyProviderWithConfig.class, provider.getClass());
-        Assert.assertEquals(provider, providers_after[position == 0 ? providers_after.length
- 1 : position - 1]);
+        Assert.assertEquals(provider, providersAfter[position == 0 ? providersAfter.length
- 1 : position - 1]);
         Assert.assertEquals(config.substring(config.lastIndexOf(":") + 1), ((DummyProviderWithConfig)
provider).getConfig());
 
 
@@ -137,19 +137,19 @@ public class SecurityProviderLoaderTest {
 
         SecurityProviderLoader.addSecurityProvider(properties);
 
-        Provider[] providers_after = Security.getProviders();
-        Assert.assertEquals(providersCountBefore + 2, providers_after.length);
+        Provider[] providersAfter = Security.getProviders();
+        Assert.assertEquals(providersCountBefore + 2, providersAfter.length);
 
         Provider provider = Security.getProvider(DummyProvider.PROVIDER_NAME);
         Provider providerWithConfig = Security.getProvider(DummyProviderWithConfig.PROVIDER_NAME);
 
         Assert.assertNotNull("Provider not installed.", provider);
         Assert.assertEquals(DummyProvider.class, provider.getClass());
-        Assert.assertEquals(provider, providers_after[0]);
+        Assert.assertEquals(provider, providersAfter[0]);
 
         Assert.assertNotNull("Provider not installed.", providerWithConfig);
         Assert.assertEquals(DummyProviderWithConfig.class, providerWithConfig.getClass());
-        Assert.assertEquals(providerWithConfig, providers_after[1]);
+        Assert.assertEquals(providerWithConfig, providersAfter[1]);
         Assert.assertEquals("CONFIG", ((DummyProviderWithConfig) providerWithConfig).getConfig());
     }
 


Mime
View raw message