jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject [jmeter] branch master updated: Correct possible thread wake-up problem and typo
Date Mon, 10 Aug 2020 17:51:43 GMT
This is an automated email from the ASF dual-hosted git repository.

fschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new 53873bc  Correct possible thread wake-up problem and typo
53873bc is described below

commit 53873bc91c6ef18c6aa56aa3e55dfa15f701e06e
Author: Felix Schumacher <felix.schumacher@internetallee.de>
AuthorDate: Mon Aug 10 19:47:08 2020 +0200

    Correct possible thread wake-up problem and typo
    
    This was noted by sonar. Usage of notify is problematic, as it could
    fail to wake-up the correct thread.
---
 .../protocol/smtp/sampler/protocol/SynchronousTransportListener.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/protocol/mail/src/main/java/org/apache/jmeter/protocol/smtp/sampler/protocol/SynchronousTransportListener.java
b/src/protocol/mail/src/main/java/org/apache/jmeter/protocol/smtp/sampler/protocol/SynchronousTransportListener.java
index b79ae0e..24bbb2a 100644
--- a/src/protocol/mail/src/main/java/org/apache/jmeter/protocol/smtp/sampler/protocol/SynchronousTransportListener.java
+++ b/src/protocol/mail/src/main/java/org/apache/jmeter/protocol/smtp/sampler/protocol/SynchronousTransportListener.java
@@ -74,7 +74,7 @@ public class SynchronousTransportListener extends TransportAdapter {
      * Synchronized-method
      * <p>
      * Waits until {@link #finish()} was called and thus the end of the mail
-     * sending was signalled.
+     * sending was signaled.
      *
      * @throws InterruptedException
      *             when interrupted while waiting with the lock
@@ -93,7 +93,7 @@ public class SynchronousTransportListener extends TransportAdapter {
     public void finish() {
         finished = true;
         synchronized(LOCK) {
-            LOCK.notify();
+            LOCK.notifyAll();
         }
     }
 


Mime
View raw message