jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject [jmeter] branch master updated: Use format message placeholder instead of string concatenation, to make code clearer
Date Sun, 09 Aug 2020 11:04:59 GMT
This is an automated email from the ASF dual-hosted git repository.

fschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new af3958b  Use format message placeholder instead of string concatenation, to make
code clearer
af3958b is described below

commit af3958b3cd5172bc60ca2d3f440febf173f45f8e
Author: Felix Schumacher <felix.schumacher@internetallee.de>
AuthorDate: Sun Aug 9 12:20:02 2020 +0200

    Use format message placeholder instead of string concatenation, to make code clearer
---
 .../src/main/java/org/apache/jmeter/assertions/HTMLAssertion.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/components/src/main/java/org/apache/jmeter/assertions/HTMLAssertion.java
b/src/components/src/main/java/org/apache/jmeter/assertions/HTMLAssertion.java
index ca2f5d6..d9c1a14 100644
--- a/src/components/src/main/java/org/apache/jmeter/assertions/HTMLAssertion.java
+++ b/src/components/src/main/java/org/apache/jmeter/assertions/HTMLAssertion.java
@@ -121,9 +121,9 @@ public class HTMLAssertion extends AbstractTestElement implements Serializable,
                     || (!isErrorsOnly() && warningsAboveThreshold)) {
                 log.debug("Errors/warnings detected while parsing with tidy: {}", errbuf);
                 result.setFailure(true);
-                result.setFailureMessage(MessageFormat.format("Tidy Parser errors:   " +
tidy.getParseErrors()
-                        + " (allowed " + getErrorThreshold() + ") " + "Tidy Parser warnings:
"
-                        + tidy.getParseWarnings() + " (allowed " + getWarningThreshold()
+ ")", new Object[0]));
+                result.setFailureMessage(MessageFormat.format(
+                        "Tidy Parser errors: {} (allowed {}) Tidy Parser warnings: {} (allowed
{})",
+                        tidy.getParseErrors(), getErrorThreshold(), tidy.getParseWarnings(),
getWarningThreshold()));
                 // return with an error
 
             } else if (tidy.getParseErrors() > 0 || tidy.getParseWarnings() > 0) {


Mime
View raw message