jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject [jmeter] branch master updated: Bug 64289 - Make httpclient4.time_to_live defaults to 60000 to be closer to typical browser behavior
Date Mon, 30 Mar 2020 07:13:06 GMT
This is an automated email from the ASF dual-hosted git repository.

pmouawad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new 9fd406b  Bug 64289 - Make httpclient4.time_to_live defaults to 60000 to be closer
to typical browser behavior
9fd406b is described below

commit 9fd406bb8f604d62981827dfe546a7027dbb76df
Author: pmouawad <p.mouawad@ubik-ingenierie.com>
AuthorDate: Mon Mar 30 09:12:44 2020 +0200

    Bug 64289 - Make httpclient4.time_to_live defaults to 60000 to be closer
    to typical browser behavior
---
 bin/jmeter.properties                                                 | 4 ++--
 .../java/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java     | 4 ++--
 xdocs/changes.xml                                                     | 1 +
 xdocs/usermanual/properties_reference.xml                             | 4 ++--
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/bin/jmeter.properties b/bin/jmeter.properties
index 0a0d638..96efa71 100644
--- a/bin/jmeter.properties
+++ b/bin/jmeter.properties
@@ -429,11 +429,11 @@ remote_hosts=127.0.0.1
 
 # Check connections if the elapsed time (Milliseconds) since the last
 # use of the connection exceed this value
-#httpclient4.validate_after_inactivity=1700
+#httpclient4.validate_after_inactivity=4900
 
 # TTL (in Milliseconds) represents an absolute value.
 # No matter what, the connection will not be re-used beyond its TTL.
-#httpclient4.time_to_live=2000
+#httpclient4.time_to_live=60000
 
 # Max size in bytes of PUT body to retain in result sampler.
 # Bigger results will be clipped.
diff --git a/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
b/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
index 8ac0e01..b24cb66 100644
--- a/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
+++ b/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
@@ -343,9 +343,9 @@ public class HTTPHC4Impl extends HTTPHCAbstractImpl {
     /** Idle timeout to be applied to connections if no Keep-Alive header is sent by the
server (default 0 = disable) */
     private static final int IDLE_TIMEOUT = JMeterUtils.getPropDefault("httpclient4.idletimeout",
0);
 
-    private static final int VALIDITY_AFTER_INACTIVITY_TIMEOUT = JMeterUtils.getPropDefault("httpclient4.validate_after_inactivity",
1700);
+    private static final int VALIDITY_AFTER_INACTIVITY_TIMEOUT = JMeterUtils.getPropDefault("httpclient4.validate_after_inactivity",
4900);
 
-    private static final int TIME_TO_LIVE = JMeterUtils.getPropDefault("httpclient4.time_to_live",
2000);
+    private static final int TIME_TO_LIVE = JMeterUtils.getPropDefault("httpclient4.time_to_live",
60000);
 
     /** Preemptive Basic Auth */
     private static final boolean BASIC_AUTH_PREEMPTIVE = JMeterUtils.getPropDefault("httpclient4.auth.preemptive",
true);
diff --git a/xdocs/changes.xml b/xdocs/changes.xml
index 12ed808..483a7bf 100644
--- a/xdocs/changes.xml
+++ b/xdocs/changes.xml
@@ -109,6 +109,7 @@ For instance: log viewer, JSR223 code editor were not previously scaled
with zoo
 <h3>HTTP Samplers and Test Script Recorder</h3>
 <ul>
     <li><bug>64160</bug>Test HTTP/S Test Script Recorder: Name transaction
controller/ simple controller using prefix without "-XXXX" suffix</li>
+    <li><bug>64289</bug>Make <code>httpclient4.time_to_live</code>
to 60000 to be closer to typical browser behavior</li>
 </ul>
 
 <h3>Other samplers</h3>
diff --git a/xdocs/usermanual/properties_reference.xml b/xdocs/usermanual/properties_reference.xml
index a520510..d54a83b 100644
--- a/xdocs/usermanual/properties_reference.xml
+++ b/xdocs/usermanual/properties_reference.xml
@@ -525,12 +525,12 @@ JMETER-SERVER</source>
 <property name="httpclient4.validate_after_inactivity">
     Check connection if the elapsed time (in milliseconds) since the last use of the connection
     exceeds this value. Ensure this value is always lower by at least 150 ms than <code>httpclient4.time_to_live</code><br/>
-    Defaults to: <code>1700</code>
+    Defaults to: <code>4900</code>
 </property>
 <property name="httpclient4.time_to_live">
     <abbr title="time to live">TTL</abbr> (in milliseconds) represents an absolute
value.
     No matter what, the connection will not be re-used beyond its TTL.<br/>
-    Defaults to: <code>2000</code>
+    Defaults to: <code>60000</code>
 </property>
 <property name="httpclient4.max_body_retain_size">
     Max size in bytes of <code>PUT</code> body to retain in result sampler.


Mime
View raw message