jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject [jmeter] branch master updated: Enhancement 62861: Fix old test plans opened as "different user on each iteration" while it should be "same user on each iteration"
Date Fri, 04 Oct 2019 20:02:13 GMT
This is an automated email from the ASF dual-hosted git repository.

pmouawad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new 538f8a2  Enhancement 62861: Fix old test plans opened as "different user on each
iteration" while it should be "same user on each iteration"
538f8a2 is described below

commit 538f8a21ba1be380d35b5c47c137a54c099d7309
Author: pmouawad <p.mouawad@ubik-ingenierie.com>
AuthorDate: Fri Oct 4 22:02:03 2019 +0200

    Enhancement 62861: Fix old test plans opened as "different user on each
    iteration" while it should be "same user on each iteration"
    
    Also update release notes
    https://bz.apache.org/bugzilla/show_bug.cgi?id=62861
---
 .../java/org/apache/jmeter/threads/gui/ThreadGroupGui.java     | 10 ++++++----
 xdocs/changes.xml                                              |  1 +
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/core/src/main/java/org/apache/jmeter/threads/gui/ThreadGroupGui.java b/src/core/src/main/java/org/apache/jmeter/threads/gui/ThreadGroupGui.java
index 80bb43e..3edcbdd 100644
--- a/src/core/src/main/java/org/apache/jmeter/threads/gui/ThreadGroupGui.java
+++ b/src/core/src/main/java/org/apache/jmeter/threads/gui/ThreadGroupGui.java
@@ -51,6 +51,8 @@ public class ThreadGroupGui extends AbstractThreadGroupGui implements ItemListen
 
     private static final String RAMP_NAME = "Ramp Up Field";
 
+    private static final boolean IS_SAME_USER_ON_NEXT_ITERATION_DEFAULT_VALUE = true;
+
     private JTextField threadInput;
 
     private JTextField rampInput;
@@ -125,7 +127,8 @@ public class ThreadGroupGui extends AbstractThreadGroupGui implements
ItemListen
 
         duration.setText(tg.getPropertyAsString(ThreadGroup.DURATION));
         delay.setText(tg.getPropertyAsString(ThreadGroup.DELAY));
-        final boolean isSameUser = tg.getPropertyAsBoolean(AbstractThreadGroup.IS_SAME_USER_ON_NEXT_ITERATION,
false);
+        final boolean isSameUser = tg.getPropertyAsBoolean(
+                AbstractThreadGroup.IS_SAME_USER_ON_NEXT_ITERATION, IS_SAME_USER_ON_NEXT_ITERATION_DEFAULT_VALUE);
         if (isSameUser){
             sameUserBox.setSelected(true);
         } else {
@@ -207,8 +210,7 @@ public class ThreadGroupGui extends AbstractThreadGroupGui implements
ItemListen
         scheduler.setSelected(false);
         delay.setText(""); // $NON-NLS-1$
         duration.setText(""); // $NON-NLS-1$
-        sameUserBox.setSelected(true);
-        differentUserBox.setSelected(false);
+        sameUserBox.setSelected(IS_SAME_USER_ON_NEXT_ITERATION_DEFAULT_VALUE);
     }
 
    private void init() { // WARNING: called from ctor so must not be overridden (i.e. must
be private or final)
@@ -273,7 +275,7 @@ public class ThreadGroupGui extends AbstractThreadGroupGui implements
ItemListen
        ButtonGroup group = new ButtonGroup();
        sameUserBox = new JRadioButton(JMeterUtils.getResString("threadgroup_same_user"));
//$NON-NLS-1$
        group.add(sameUserBox);
-       sameUserBox.setSelected(true);
+       sameUserBox.setSelected(IS_SAME_USER_ON_NEXT_ITERATION_DEFAULT_VALUE);
        differentUserBox = new JRadioButton(JMeterUtils.getResString("threadgroup_different_user"));
//$NON-NLS-1$
        group.add(differentUserBox);
        JPanel optionsPanel = new HorizontalPanel();
diff --git a/xdocs/changes.xml b/xdocs/changes.xml
index 10b7c98..e415c6d 100644
--- a/xdocs/changes.xml
+++ b/xdocs/changes.xml
@@ -162,6 +162,7 @@ to view the last release notes of version 5.1.1.
     <li>Updated to Mozilla Rhino 1.7.11 (from 1.7.10)</li>
     <li>Updated to Saxon-HE 9.9.1-5 (from 9.9.1-1)</li>
     <li>Updated to slf4j 1.7.28 (from 1.7.25)</li>
+    <li><bug>62861</bug>Thread Group: Provide ability to configure whether
a new iteration is a new user or same user (Would be applied on Cookie Manager, Cache Manager
and httpclient.reset_state_on_thread_group_iteration). Contributed by Ubik Load Pack (support
at ubikloadpack.com)</li>
     <li><bug>63396</bug>JSR223 Test Elements: Description of Parameters
is misleading, same for Script</li>
     <li><bug>63480</bug>XPathAssertion and XPathAssertion2: Improve test
coverage for input coming from variable. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
     <li><bug>63452</bug>Tools / Import from cURL: Complete coverage of
all command line options that are valid in JMeter use case. Contributed by Ubik Load Pack
(support at ubikloadpack.com)</li>


Mime
View raw message