From commits-return-9978-apmail-jmeter-commits-archive=jmeter.apache.org@jmeter.apache.org Sat Sep 28 16:51:16 2019 Return-Path: X-Original-To: apmail-jmeter-commits-archive@minotaur.apache.org Delivered-To: apmail-jmeter-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id A90ED19CAF for ; Sat, 28 Sep 2019 16:51:16 +0000 (UTC) Received: (qmail 96082 invoked by uid 500); 28 Sep 2019 16:51:16 -0000 Delivered-To: apmail-jmeter-commits-archive@jmeter.apache.org Received: (qmail 96060 invoked by uid 500); 28 Sep 2019 16:51:16 -0000 Mailing-List: contact commits-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list commits@jmeter.apache.org Received: (qmail 96040 invoked by uid 99); 28 Sep 2019 16:51:16 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Sep 2019 16:51:16 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id D1AEC81E73; Sat, 28 Sep 2019 16:51:15 +0000 (UTC) Date: Sat, 28 Sep 2019 16:51:15 +0000 To: "commits@jmeter.apache.org" Subject: [jmeter] branch master updated: Remove new SecureRandom().generateSeed(128) as it exhausts entropy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <156968947574.25757.1631050959522121558@gitbox.apache.org> From: vladimirsitnikov@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: jmeter X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 816f58fe4dcbe647240812257ef1c36fcc8265fa X-Git-Newrev: 259fafa4ba1ed5b607d0aca0459e10df221f36da X-Git-Rev: 259fafa4ba1ed5b607d0aca0459e10df221f36da X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/jmeter.git The following commit(s) were added to refs/heads/master by this push: new 259fafa Remove new SecureRandom().generateSeed(128) as it exhausts entropy 259fafa is described below commit 259fafa4ba1ed5b607d0aca0459e10df221f36da Author: Vladimir Sitnikov AuthorDate: Sat Sep 28 19:50:39 2019 +0300 Remove new SecureRandom().generateSeed(128) as it exhausts entropy Here's a stacktrace: "main" #1 prio=5 os_prio=0 tid=0x00007f507400c800 nid=0x33d2 runnable [0x00007f507aaa0000] java.lang.Thread.State: RUNNABLE at java.io.FileInputStream.readBytes(Native Method) at java.io.FileInputStream.read(FileInputStream.java:255) at sun.security.provider.NativePRNG$RandomIO.readFully(NativePRNG.java:424) at sun.security.provider.NativePRNG$RandomIO.implGenerateSeed(NativePRNG.java:441) - locked <0x00000000ffb11238> (a java.lang.Object) at sun.security.provider.NativePRNG$RandomIO.access$500(NativePRNG.java:331) at sun.security.provider.NativePRNG.engineGenerateSeed(NativePRNG.java:226) at java.security.SecureRandom.generateSeed(SecureRandom.java:533) at org.apache.jorphan.util.JOrphanUtils.(JOrphanUtils.java:52) at org.apache.jmeter.util.JMeterUtils.loadJMeterProperties(JMeterUtils.java:213) at org.apache.jmeter.JMeter.initializeProperties(JMeter.java:788) at org.apache.jmeter.JMeter.start(JMeter.java:461) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.jmeter.NewDriver.main(NewDriver.java:253) --- src/jorphan/src/main/java/org/apache/jorphan/util/JOrphanUtils.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/jorphan/src/main/java/org/apache/jorphan/util/JOrphanUtils.java b/src/jorphan/src/main/java/org/apache/jorphan/util/JOrphanUtils.java index d301a2a..ccae263 100644 --- a/src/jorphan/src/main/java/org/apache/jorphan/util/JOrphanUtils.java +++ b/src/jorphan/src/main/java/org/apache/jorphan/util/JOrphanUtils.java @@ -40,16 +40,12 @@ import org.apache.commons.text.RandomStringGenerator; /** * This class contains frequently-used static utility methods. - * */ - -// @see TestJorphanUtils for unit tests - public final class JOrphanUtils { private static final int DEFAULT_CHUNK_SIZE = 4096; - private static final SecureRandom SECURE_RANDOM = new SecureRandom(new SecureRandom().generateSeed(128)); + private static final SecureRandom SECURE_RANDOM = new SecureRandom(); /** * Private constructor to prevent instantiation. */