jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1828416 - in /jmeter/trunk: src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java xdocs/changes.xml
Date Thu, 05 Apr 2018 11:03:13 GMT
Author: pmouawad
Date: Thu Apr  5 11:03:13 2018
New Revision: 1828416

URL: http://svn.apache.org/viewvc?rev=1828416&view=rev
Log:
Bug 62251 - TextGraphiteMetricsSender does not invalidate lost connections in case of network
errors 
Bugzilla Id: 62251

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java?rev=1828416&r1=1828415&r2=1828416&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java
(original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java
Thu Apr  5 11:03:13 2018
@@ -109,7 +109,12 @@ class TextGraphiteMetricsSender extends
                 if (log.isDebugEnabled()) {
                     log.debug("Wrote {} metrics", copyMetrics.size());
                 }
-                socketOutputStreamPool.returnObject(socketConnectionInfos, out);
+                if(pw.checkError()) {
+                    socketOutputStreamPool.invalidateObject(socketConnectionInfos, out);
+                    log.error("IO Errors writing to Graphite, some data will be lost");
+                } else {
+                    socketOutputStreamPool.returnObject(socketConnectionInfos, out);
+                }
             } catch (Exception e) {
                 if(out != null) {
                     try {

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1828416&r1=1828415&r2=1828416&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Thu Apr  5 11:03:13 2018
@@ -172,6 +172,7 @@ this behaviour, set <code>httpclient.res
 <ul>
   <li><bug>62097</bug>Update JTable in Aggregate Report only when new data
has arrived. That way selections of rows will be kept longer around.</li>
   <li><bug>62203</bug>Influxdb BackendListener client: store user tags
to annotation and internal transaction. Contributed by Sergey Batalin (sergey_batalin at mail.ru)</li>
+  <li><bug>62251</bug>TextGraphiteMetricsSender does not invalidate lost
connections in case of network errors </li>
 </ul>
 
 <h3>Timers, Assertions, Config, Pre- &amp; Post-Processors</h3>



Mime
View raw message